tests: use test_config --git-dir for bare repos

As part of the preparation for `safe.bareRepository` defaulting to
`explicit` (see 8d1a744), switch `test_config -C <bare>` to
`test_config --git-dir <bare>` so the config helper accesses bare repos
without implicit discovery.

For your convenience, here is an awk command-line to verify this commit:
It mechanically undoes the transformation on the new lines; empty output
is success:

    git diff HEAD^! | awk '
      /^diff/,/^\+\+\+/ { next }
      /^-/ { old[m++] = substr($0,2) }
      /^\+/ {
        new = substr($0,2)
        # undo: --git-dir -> -C
        gsub(/test_config --git-dir /, "test_config -C ", new)
        if (old[n++] != new) print old[n-1] " != " new
      }'

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

t/t5410-receive-pack.sh

@@ -26,15 +26,15 @@ test_expect_success 'with core.alternateRefsCommand' '
 			--format="%(objectname)" \
 			refs/heads/public/
 	EOF
-	test_config -C fork core.alternateRefsCommand ./alternate-refs &&
+	test_config --git-dir fork core.alternateRefsCommand ./alternate-refs &&
 	git rev-parse public/branch >expect &&
 	printf "0000" | git receive-pack fork >actual &&
 	extract_haves <actual >actual.haves &&
 	test_cmp expect actual.haves
 '
 
 test_expect_success 'with core.alternateRefsPrefixes' '
-	test_config -C fork core.alternateRefsPrefixes "refs/heads/private" &&
+	test_config --git-dir fork core.alternateRefsPrefixes "refs/heads/private" &&
 	git rev-parse private/branch >expect &&
 	printf "0000" | git receive-pack fork >actual &&
 	extract_haves <actual >actual.haves &&

t/t5509-fetch-push-namespaces.sh

@@ -114,25 +114,25 @@ test_expect_success 'hide full refs with transfer.hideRefs' '
 '
 
 test_expect_success 'try to update a hidden ref' '
-	test_config -C pushee transfer.hideRefs refs/heads/main &&
+	test_config --git-dir pushee transfer.hideRefs refs/heads/main &&
 	test_must_fail git -C original push pushee-namespaced main
 '
 
 test_expect_success 'try to update a ref that is not hidden' '
-	test_config -C pushee transfer.hideRefs refs/namespaces/namespace/refs/heads/main &&
+	test_config --git-dir pushee transfer.hideRefs refs/namespaces/namespace/refs/heads/main &&
 	git -C original push pushee-namespaced main
 '
 
 test_expect_success 'git-receive-pack(1) with transfer.hideRefs does not match unstripped refs during advertisement' '
 	git -C pushee update-ref refs/namespaces/namespace/refs/heads/foo/1 refs/namespaces/namespace/refs/heads/main &&
 	git -C pushee pack-refs --all &&
-	test_config -C pushee transfer.hideRefs refs/namespaces/namespace/refs/heads/foo &&
+	test_config --git-dir pushee transfer.hideRefs refs/namespaces/namespace/refs/heads/foo &&
 	GIT_TRACE_PACKET="$(pwd)/trace" git -C original push pushee-namespaced main &&
 	test_grep refs/heads/foo/1 trace
 '
 
 test_expect_success 'try to update a hidden full ref' '
-	test_config -C pushee transfer.hideRefs "^refs/namespaces/namespace/refs/heads/main" &&
+	test_config --git-dir pushee transfer.hideRefs "^refs/namespaces/namespace/refs/heads/main" &&
 	test_must_fail git -C original push pushee-namespaced main
 '
 

t/t5606-clone-options.sh

@@ -171,7 +171,7 @@ test_expect_success 'clone does not segfault with --bare and core.bare=false' '
 test_expect_success 'chooses correct default initial branch name' '
 	GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= \
 	git -c init.defaultBranch=foo init --bare empty &&
-	test_config -C empty lsrefs.unborn advertise &&
+	test_config --git-dir empty lsrefs.unborn advertise &&
 	GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME= \
 	git -c init.defaultBranch=up -c protocol.version=2 clone empty whats-up &&
 	test refs/heads/foo = $(git -C whats-up symbolic-ref HEAD) &&

t/t5616-partial-clone.sh

@@ -357,40 +357,40 @@ test_expect_success 'upload-pack complains of bogus filter config' '
 '
 
 test_expect_success 'upload-pack fails banned object filters' '
-	test_config -C srv.bare uploadpackfilter.blob:none.allow false &&
+	test_config --git-dir srv.bare uploadpackfilter.blob:none.allow false &&
 	test_must_fail ok=sigpipe git clone --no-checkout --filter=blob:none \
 		"file://$(pwd)/srv.bare" pc3 2>err &&
 	test_grep "filter '\''blob:none'\'' not supported" err
 '
 
 test_expect_success 'upload-pack fails banned combine object filters' '
-	test_config -C srv.bare uploadpackfilter.allow false &&
-	test_config -C srv.bare uploadpackfilter.combine.allow true &&
-	test_config -C srv.bare uploadpackfilter.tree.allow true &&
-	test_config -C srv.bare uploadpackfilter.blob:none.allow false &&
+	test_config --git-dir srv.bare uploadpackfilter.allow false &&
+	test_config --git-dir srv.bare uploadpackfilter.combine.allow true &&
+	test_config --git-dir srv.bare uploadpackfilter.tree.allow true &&
+	test_config --git-dir srv.bare uploadpackfilter.blob:none.allow false &&
 	test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
 		--filter=blob:none "file://$(pwd)/srv.bare" pc3 2>err &&
 	test_grep "filter '\''blob:none'\'' not supported" err
 '
 
 test_expect_success 'upload-pack fails banned object filters with fallback' '
-	test_config -C srv.bare uploadpackfilter.allow false &&
+	test_config --git-dir srv.bare uploadpackfilter.allow false &&
 	test_must_fail ok=sigpipe git clone --no-checkout --filter=blob:none \
 		"file://$(pwd)/srv.bare" pc3 2>err &&
 	test_grep "filter '\''blob:none'\'' not supported" err
 '
 
 test_expect_success 'upload-pack limits tree depth filters' '
-	test_config -C srv.bare uploadpackfilter.allow false &&
-	test_config -C srv.bare uploadpackfilter.tree.allow true &&
-	test_config -C srv.bare uploadpackfilter.tree.maxDepth 0 &&
+	test_config --git-dir srv.bare uploadpackfilter.allow false &&
+	test_config --git-dir srv.bare uploadpackfilter.tree.allow true &&
+	test_config --git-dir srv.bare uploadpackfilter.tree.maxDepth 0 &&
 	test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:1 \
 		"file://$(pwd)/srv.bare" pc3 2>err &&
 	test_grep "tree filter allows max depth 0, but got 1" err &&
 
 	git clone --no-checkout --filter=tree:0 "file://$(pwd)/srv.bare" pc4 &&
 
-	test_config -C srv.bare uploadpackfilter.tree.maxDepth 5 &&
+	test_config --git-dir srv.bare uploadpackfilter.tree.maxDepth 5 &&
 	git clone --no-checkout --filter=tree:5 "file://$(pwd)/srv.bare" pc5 &&
 	test_must_fail ok=sigpipe git clone --no-checkout --filter=tree:6 \
 		"file://$(pwd)/srv.bare" pc6 2>err &&

t/t5620-backfill.sh

@@ -183,8 +183,8 @@ test_expect_success 'create a partial clone over HTTP' '
 	SERVER="$HTTPD_DOCUMENT_ROOT_PATH/server" &&
 	rm -rf "$SERVER" repo &&
 	git clone --bare "file://$(pwd)/src" "$SERVER" &&
-	test_config -C "$SERVER" uploadpack.allowfilter 1 &&
-	test_config -C "$SERVER" uploadpack.allowanysha1inwant 1 &&
+	test_config --git-dir "$SERVER" uploadpack.allowfilter 1 &&
+	test_config --git-dir "$SERVER" uploadpack.allowanysha1inwant 1 &&
 
 	git clone --no-checkout --filter=blob:none \
 		"$HTTPD_URL/smart/server" backfill-http

t/t5710-promisor-remote-capability.sh

@@ -304,7 +304,7 @@ test_expect_success "clone with promisor.sendFields" '
 	git -C server config remote.otherLop.stuff "baz" &&
 	git -C server config remote.otherLop.partialCloneFilter "blob:limit=10k" &&
 	test_when_finished "git -C server remote remove otherLop" &&
-	test_config -C server promisor.sendFields "partialCloneFilter, token" &&
+	test_config --git-dir server promisor.sendFields "partialCloneFilter, token" &&
 	test_when_finished "rm trace" &&
 
 	# Clone from server to create a client
@@ -335,7 +335,7 @@ test_expect_success "clone with promisor.checkFields" '
 	git -C server config remote.otherLop.stuff "baz" &&
 	git -C server config remote.otherLop.partialCloneFilter "blob:limit=10k" &&
 	test_when_finished "git -C server remote remove otherLop" &&
-	test_config -C server promisor.sendFields "partialCloneFilter, token" &&
+	test_config --git-dir server promisor.sendFields "partialCloneFilter, token" &&
 	test_when_finished "rm trace" &&
 
 	# Clone from server to create a client
@@ -373,7 +373,7 @@ test_expect_success "clone with promisor.storeFields=partialCloneFilter" '
 	git -C server config remote.lop.token "fooXXX" &&
 	git -C server config remote.lop.partialCloneFilter "blob:limit=8k" &&
 
-	test_config -C server promisor.sendFields "partialCloneFilter, token" &&
+	test_config --git-dir server promisor.sendFields "partialCloneFilter, token" &&
 	test_when_finished "rm trace" &&
 
 	# Clone from server to create a client
@@ -428,7 +428,7 @@ test_expect_success "clone and fetch with --filter=auto" '
 	test_when_finished "rm -rf client trace" &&
 
 	git -C server config remote.lop.partialCloneFilter "blob:limit=9500" &&
-	test_config -C server promisor.sendFields "partialCloneFilter" &&
+	test_config --git-dir server promisor.sendFields "partialCloneFilter" &&
 
 	GIT_TRACE_PACKET="$(pwd)/trace" GIT_NO_LAZY_FETCH=0 git clone \
 		-c remote.lop.promisor=true \

t/t7700-repack.sh

@@ -320,7 +320,7 @@ test_expect_success 'no bitmaps created if .keep files present' '
 '
 
 test_expect_success 'auto-bitmaps do not complain if unavailable' '
-	test_config -C bare.git pack.packSizeLimit 1M &&
+	test_config --git-dir bare.git pack.packSizeLimit 1M &&
 	blob=$(test-tool genrandom big 1m |
 	       git -C bare.git hash-object -w --stdin) &&
 	git -C bare.git update-ref refs/tags/big $blob &&