Include the LintCommit configuration in IConfig

This way, the maximal number of columns can be configured freely per
project, via the project-specific config.

To reduce friction for on-boarding new projects by not having to look
in multiple locations when creating a config file, the definition of the
`ILintCommitConfig` interface is moved to `project-config.ts`, where all
the other project-specific interfaces live already.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -1037,7 +1037,7 @@ export class CIHelper {
 
         if (result) {
             const results = commits.map((commit: IPRCommit) => {
-                const linter = new LintCommit(commit);
+                const linter = new LintCommit(commit, this.config.lint.commitLintOptions);
                 return linter.lint();
             });
 

lib/commit-lint.ts

@@ -1,14 +1,11 @@
 import { IPRCommit } from "./github-glue.js";
+import { ILintCommitConfig } from "./project-config.js";
 
 export interface ILintError {
     checkFailed: boolean; // true if check failed
     message: string;
 }
 
-export interface ILintOptions {
-    maxColumns?: number | undefined; // max line length
-}
-
 /*
  * Simple single use class to drive lint tests on commit messages.
  */
@@ -19,7 +16,7 @@ export class LintCommit {
     private messages: string[] = [];
     private maxColumns = 76;
 
-    public constructor(patch: IPRCommit, options?: ILintOptions) {
+    public constructor(patch: IPRCommit, options?: ILintCommitConfig) {
         this.blocked = false;
         this.lines = patch.message.split("\n");
         this.patch = patch;

lib/project-config.ts

@@ -48,9 +48,14 @@ export interface IAppConfig {
     altname: string | undefined; // is this even needed?
 }
 
+export interface ILintCommitConfig {
+    maxColumns?: number | undefined; // max line length
+}
+
 export interface ILintConfig {
     maxCommitsIgnore?: string[]; // array of pull request urls to skip check
     maxCommits: number; // limit on number of commits in a pull request
+    commitLintOptions?: ILintCommitConfig; // options to pass to commit linter
 }
 
 export interface IUserConfig {

tests/commit-lint.test.ts

@@ -1,6 +1,7 @@
 import { expect, jest, test } from "@jest/globals";
-import { ILintError, ILintOptions, LintCommit } from "../lib/commit-lint.js";
+import { ILintError, LintCommit } from "../lib/commit-lint.js";
 import { IPRCommit } from "../lib/github-glue.js";
+import { ILintCommitConfig } from "../lib/project-config.js";
 
 jest.setTimeout(180000);
 
@@ -15,7 +16,7 @@ jest.setTimeout(180000);
  * @param check a function to verify the lint result
  * @param options extra linter options, if any
  */
-function lintCheck(commit: IPRCommit, check?: (error: ILintError) => void, options?: ILintOptions) {
+function lintCheck(commit: IPRCommit, check?: (error: ILintError) => void, options?: ILintCommitConfig) {
     const linter = new LintCommit(commit, options);
     const lintError = linter.lint();
     if (!check) {