Skip to content

Commit a9a9d42

Browse files
committed
merge-ort: pass repository to write_tree()
In order to get rid of a usage of the_repository, we need to know the value of opt->repo; pass it along to write_tree(). Once we have the repository, though, we no longer need to pass opt->repo->hash_algo->rawsz, we can have write_tree() look up that value itself. Signed-off-by: Elijah Newren <newren@gmail.com>
1 parent e75334a commit a9a9d42

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

merge-ort.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3822,15 +3822,16 @@ static int tree_entry_order(const void *a_, const void *b_)
38223822
b->string, strlen(b->string), bmi->result.mode);
38233823
}
38243824

3825-
static int write_tree(struct object_id *result_oid,
3825+
static int write_tree(struct repository *repo,
3826+
struct object_id *result_oid,
38263827
struct string_list *versions,
3827-
unsigned int offset,
3828-
size_t hash_size)
3828+
unsigned int offset)
38293829
{
38303830
size_t maxlen = 0, extra;
38313831
unsigned int nr;
38323832
struct strbuf buf = STRBUF_INIT;
38333833
int i, ret = 0;
3834+
size_t hash_size = repo->hash_algo->rawsz;
38343835

38353836
assert(offset <= versions->nr);
38363837
nr = versions->nr - offset;
@@ -3856,7 +3857,7 @@ static int write_tree(struct object_id *result_oid,
38563857
}
38573858

38583859
/* Write this object file out, and record in result_oid */
3859-
if (odb_write_object(the_repository->objects, buf.buf,
3860+
if (odb_write_object(repo->objects, buf.buf,
38603861
buf.len, OBJ_TREE, result_oid))
38613862
ret = -1;
38623863
strbuf_release(&buf);
@@ -4026,8 +4027,8 @@ static int write_completed_directory(struct merge_options *opt,
40264027
dir_info->is_null = 0;
40274028
dir_info->result.mode = S_IFDIR;
40284029
if (record_tree &&
4029-
write_tree(&dir_info->result.oid, &info->versions, offset,
4030-
opt->repo->hash_algo->rawsz) < 0)
4030+
write_tree(opt->repo, &dir_info->result.oid, &info->versions,
4031+
offset) < 0)
40314032
ret = -1;
40324033
}
40334034

@@ -4573,8 +4574,7 @@ static int process_entries(struct merge_options *opt,
45734574
BUG("dir_metadata accounting completely off; shouldn't happen");
45744575
}
45754576
if (record_tree &&
4576-
write_tree(result_oid, &dir_metadata.versions, 0,
4577-
opt->repo->hash_algo->rawsz) < 0)
4577+
write_tree(opt->repo, result_oid, &dir_metadata.versions, 0) < 0)
45784578
ret = -1;
45794579
cleanup:
45804580
string_list_clear(&plist, 0);

0 commit comments

Comments
 (0)