Skip to content

Commit bd66ed3

Browse files
committed
regexp: leave a pointer to resurrect workaround for Homebrew
Recently some GitHub CI jobs were broken by update on the platform side, which was eventually resolved by image rollback, but in the meantime Dscho invented a workaround patch to sidestep the broken part of the platform. Their future image update may contain the same bug, in which case the workaround may again become needed. As we do not want to be building with workaround that avoids system regexp library altogether unless the system is known to be broken, so short of an automated "detect broken system and apply workaround" mechanism, let's use the folks who are compiling the code to detect breakage on their system and cope with the breakage ;-) Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 41688c1 commit bd66ed3

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

compat/regcomp_enhanced.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33

44
int git_regcomp(regex_t *preg, const char *pattern, int cflags)
55
{
6+
/*
7+
* If you are on macOS with clang and fail to compile this line,
8+
* https://lore.kernel.org/git/458ad3c1-96df-4575-ee42-e6eb754f25f6@gmx.de/
9+
* might be relevant.
10+
*/
611
if (!(cflags & REG_EXTENDED))
712
cflags |= REG_ENHANCED;
813
return regcomp(preg, pattern, cflags);

0 commit comments

Comments
 (0)