mingw: use strftime() directly in UCRT builds#2079
mingw: use strftime() directly in UCRT builds#2079dscho wants to merge 1 commit intogitgitgadget:masterfrom
Conversation
The `mingw_strftime()` wrapper exists to work around msvcrt.dll's incomplete `strftime()` implementation by dynamically loading the version from ucrtbase.dll at runtime via `LoadLibrary()` + `GetProcAddress()`. When the binary is already linked against UCRT (i.e. when building in the UCRT64 environment), the linked-in `strftime()` is the ucrtbase.dll version, making the dynamic loading needless churn: It's calling the very same code. Simply guard both the declaration and implementation so that the unnecessary work-around is skipped in UCRT builds. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
/submit |
|
Submitted as pull.2079.git.1775210183103.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This patch series was integrated into seen via git@d914313. |
|
This patch series was integrated into next via git@3ed53e1. |
|
This branch is now known as |
|
This patch series was integrated into seen via git@e1bfba5. |
|
This patch series was integrated into master via git@e1bfba5. |
|
This patch series was integrated into next via git@e1bfba5. |
|
Congratulations! 🎉 Your patch series was merged into upstream via e1bfba5. Note: this pull request will show as "Closed" rather than "Merged" because the merge happened in the upstream repository, not on GitHub. This is expected — your contribution has been accepted! |
1 participant
Since the MSYS2 project deprecated the MINGW64 environment on which Git for Windows relies, we have to prepare quite swiftly for a future where we switch to the UCRT64 environment instead. This patch is the only fall-out of that that concerns the Git source code.