refactor: address review feedback — mechanism-agnostic log, stronger tests

- Reword partial-success log messages to remove SQS reference; add
  created/requested counts to log metadata
- ScaleError test now uses numberOfRunners=3 to validate failedInstanceCount
- Partial-success test now requests 3 runners and gets 1 back (truly partial)

Author: vegardx

lambdas/functions/control-plane/src/aws/runners.test.ts

@@ -511,13 +511,15 @@ describe('create runner with errors', () => {
   it('test ScaleError with multiple error.', async () => {
     createFleetMockWithErrors(['UnfulfillableCapacity', 'MaxSpotInstanceCountExceeded', 'NotMappedError']);
 
-    await expect(createRunner(createRunnerConfig(defaultRunnerConfig))).rejects.toMatchObject({
+    await expect(
+      createRunner({ ...createRunnerConfig(defaultRunnerConfig), numberOfRunners: 3 }),
+    ).rejects.toMatchObject({
       name: 'ScaleError',
-      failedInstanceCount: 1, // numberOfRunners when zero instances created
+      failedInstanceCount: 3, // numberOfRunners when zero instances created
     });
     expect(mockEC2Client).toHaveReceivedCommandWith(
       CreateFleetCommand,
-      expectedCreateFleetRequest(defaultExpectedFleetRequestValues),
+      expectedCreateFleetRequest({ ...defaultExpectedFleetRequestValues, totalTargetCapacity: 3 }),
     );
     expect(mockSSMClient).not.toHaveReceivedCommand(PutParameterCommand);
   });
@@ -546,10 +548,12 @@ describe('create runner with errors', () => {
   it('returns partial instances on recognized scale error instead of throwing', async () => {
     createFleetMockWithErrors(['UnfulfillableCapacity'], ['i-partial']);
 
-    await expect(createRunner(createRunnerConfig(defaultRunnerConfig))).resolves.toEqual(['i-partial']);
+    await expect(
+      createRunner({ ...createRunnerConfig(defaultRunnerConfig), numberOfRunners: 3 }),
+    ).resolves.toEqual(['i-partial']);
     expect(mockEC2Client).toHaveReceivedCommandWith(
       CreateFleetCommand,
-      expectedCreateFleetRequest(defaultExpectedFleetRequestValues),
+      expectedCreateFleetRequest({ ...defaultExpectedFleetRequestValues, totalTargetCapacity: 3 }),
     );
   });
 

lambdas/functions/control-plane/src/aws/runners.ts

@@ -204,8 +204,8 @@ async function processFleetResult(
     if (instances.length > 0) {
       logger.warn(
         `Partial fleet success: ${instances.length}/${runnerParameters.numberOfRunners} instances created. ` +
-          `Returning partial results; caller will retry the shortfall via SQS.`,
-        { data: fleet.Errors },
+          `Returning partial results; unfulfilled requests remain for retry.`,
+        { data: fleet.Errors, created: instances.length, requested: runnerParameters.numberOfRunners },
       );
       return instances;
     }
@@ -218,7 +218,7 @@ async function processFleetResult(
     logger.warn(
       `Partial fleet success: ${instances.length}/${runnerParameters.numberOfRunners} instances created. ` +
         `Error not recognized as scaling error; returning partial results.`,
-      { data: fleet.Errors },
+      { data: fleet.Errors, created: instances.length, requested: runnerParameters.numberOfRunners },
     );
     return instances;
   }