Skip to content

fix(ssm): ignore_changes for insecure_value/version on github_app SSM params #5114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnezell wants to merge 1 commit into from
+18 −0
Closed

fix(ssm): ignore_changes for insecure_value/version on github_app SSM params #5114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions modules/ssm/ssm.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ resource "aws_ssm_parameter" "github_app_id" {
value = var.github_app.id
key_id = local.kms_key_arn
tags = var.tags

# The AWS provider exposes `insecure_value` as a computed/optional attribute and
# surfaces a "+ insecure_value = (known after apply)" diff on every plan for
# SecureString params (the API never returns it). `version` similarly drifts to
# "(known after apply)" because the provider treats it as recomputed. Neither
# actually changes anything on apply — ignore them to silence perpetual no-op
# drift for consumers of this module.
lifecycle {
ignore_changes = [insecure_value, version]
}
}

resource "aws_ssm_parameter" "github_app_key_base64" {
Expand All @@ -14,6 +24,10 @@ resource "aws_ssm_parameter" "github_app_key_base64" {
value = var.github_app.key_base64
key_id = local.kms_key_arn
tags = var.tags

lifecycle {
ignore_changes = [insecure_value, version]
}
}

resource "aws_ssm_parameter" "github_app_webhook_secret" {
Expand All @@ -23,4 +37,8 @@ resource "aws_ssm_parameter" "github_app_webhook_secret" {
value = var.github_app.webhook_secret
key_id = local.kms_key_arn
tags = var.tags

lifecycle {
ignore_changes = [insecure_value, version]
}
}