fix: retry installation auth for regional GitHub App events#5123
Open
bogdankrasko wants to merge 1 commit into
Open
fix: retry installation auth for regional GitHub App events#5123bogdankrasko wants to merge 1 commit into
bogdankrasko wants to merge 1 commit into
Conversation
Handle webhook events whose installationId belongs to a different GitHub App by retrying installation authentication after a 404. Apply the fallback in both the shared Octokit helper and the scale-up flow by re-resolving the installation ID for the current app before retrying auth. Preserve existing behavior for installationId=0 and non-404 errors, and add regression tests covering the mismatched installation/app scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle webhook events whose installationId belongs to a different GitHub App by retrying installation authentication after a 404.
Apply the fallback in both the shared Octokit helper and the scale-up flow by re-resolving the installation ID for the current app before retrying auth.
Preserve existing behavior for installationId=0 and non-404 errors, and add regression tests covering the mismatched installation/app scenario.
Test Plan
Follow the instructions in #5099 to deploy runners to multiple regions, and set the GitHub App secrets in SSM so that each region has its own GitHub App ID.
Related Issues