Skip to content

Commit 281272f

Browse files
zkoppertCopilot
andcommitted
fix: resolve zizmor workflow linter findings
Add permission comments, concurrency groups, job names, and fix template injection patterns across all workflow files to satisfy zizmor pedantic checks run by Super-Linter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 7d7878d commit 281272f

13 files changed

Lines changed: 64 additions & 27 deletions

.github/workflows/auto-labeler.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
main:
1111
permissions:
1212
contents: read
13-
pull-requests: write
13+
pull-requests: write # Required to label PRs
1414
uses: github-community-projects/ospo-reusable-workflows/.github/workflows/auto-labeler.yaml@3b691dff6b68489c8548e1295d125c93c9c29a4e
1515
with:
1616
config-name: release-drafter.yml

.github/workflows/codeql.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ on:
2020
schedule:
2121
- cron: "0 0 * * 1"
2222

23+
concurrency:
24+
group: ${{ github.workflow }}-${{ github.ref }}
25+
cancel-in-progress: true
26+
2327
permissions:
2428
contents: read
2529

@@ -28,9 +32,9 @@ jobs:
2832
name: Analyze
2933
runs-on: ubuntu-latest
3034
permissions:
31-
actions: read
32-
contents: read
33-
security-events: write
35+
actions: read # Required for CodeQL analysis
36+
contents: read # Required to checkout code
37+
security-events: write # Required to upload SARIF results
3438

3539
strategy:
3640
fail-fast: false

.github/workflows/contributors_report.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ on:
55
schedule:
66
- cron: "3 2 1 * *"
77

8+
concurrency:
9+
group: ${{ github.workflow }}-${{ github.ref }}
10+
cancel-in-progress: false
11+
812
permissions:
913
contents: read
1014

@@ -13,7 +17,7 @@ jobs:
1317
name: contributor report
1418
runs-on: ubuntu-latest
1519
permissions:
16-
issues: write
20+
issues: write # Required to create/update issues
1721

1822
steps:
1923
- name: Harden the runner (Audit all outbound calls)

.github/workflows/copilot-setup-steps.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ on:
1111
paths:
1212
- .github/workflows/copilot-setup-steps.yml
1313

14+
concurrency:
15+
group: ${{ github.workflow }}-${{ github.ref }}
16+
cancel-in-progress: true
17+
1418
# Set the permissions to the lowest permissions possible needed for your steps.
1519
# Copilot will be given its own token for its operations.
1620
permissions:
@@ -20,6 +24,7 @@ permissions:
2024
jobs:
2125
# The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
2226
copilot-setup-steps:
27+
name: Copilot setup steps
2328
runs-on: ubuntu-latest
2429

2530
# You can define any steps you want, and they will run before the agent starts.

.github/workflows/dependency-review.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,16 @@
99
name: "Dependency Review"
1010
on: [pull_request]
1111

12+
concurrency:
13+
group: ${{ github.workflow }}-${{ github.ref }}
14+
cancel-in-progress: true
15+
1216
permissions:
1317
contents: read
1418

1519
jobs:
1620
dependency-review:
21+
name: Dependency review
1722
runs-on: ubuntu-latest
1823
steps:
1924
- name: Harden the runner (Audit all outbound calls)

.github/workflows/docker-ci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,16 @@ on:
77
pull_request:
88
branches: [main]
99

10+
concurrency:
11+
group: ${{ github.workflow }}-${{ github.ref }}
12+
cancel-in-progress: true
13+
1014
permissions:
1115
contents: read
1216

1317
jobs:
1418
build:
19+
name: Build Docker image
1520
runs-on: ubuntu-latest
1621
steps:
1722
- name: Harden the runner (Audit all outbound calls)

.github/workflows/mark-ready-when-ready.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
name: Mark as ready after successful checks
1717
runs-on: ubuntu-latest
1818
permissions:
19-
checks: read
20-
contents: write
21-
pull-requests: write
22-
statuses: read
19+
checks: read # Required to read check run results
20+
contents: write # Required to merge PRs
21+
pull-requests: write # Required to update PR status
22+
statuses: read # Required to read check statuses
2323
if: |
2424
contains(github.event.pull_request.labels.*.name, 'Mark Ready When Ready') &&
2525
github.event.pull_request.draft == true

.github/workflows/pr-title.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ jobs:
1010
main:
1111
permissions:
1212
contents: read
13-
pull-requests: read
14-
statuses: write
13+
pull-requests: read # Required to read PR metadata
14+
statuses: write # Required to update commit statuses
1515
uses: github-community-projects/ospo-reusable-workflows/.github/workflows/pr-title.yaml@3b691dff6b68489c8548e1295d125c93c9c29a4e
1616
secrets:
1717
github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/python-ci.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ permissions:
1919

2020
jobs:
2121
build:
22+
name: Build and test
2223
runs-on: ubuntu-latest
2324
strategy:
2425
matrix:
@@ -38,9 +39,13 @@ jobs:
3839
version: "0.10.9"
3940
enable-cache: true
4041
- name: Set up Python ${{ matrix.python-version }}
41-
run: uv python install ${{ matrix.python-version }}
42+
env:
43+
PYTHON_VERSION: ${{ matrix.python-version }}
44+
run: uv python install "$PYTHON_VERSION"
4245
- name: Install dependencies
43-
run: uv sync --frozen --python ${{ matrix.python-version }}
46+
env:
47+
PYTHON_VERSION: ${{ matrix.python-version }}
48+
run: uv sync --frozen --python "$PYTHON_VERSION"
4449
- name: Lint with flake8 and pylint
4550
run: |
4651
make lint

.github/workflows/release.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ permissions:
1010
jobs:
1111
release:
1212
permissions:
13-
contents: write
14-
pull-requests: read
13+
contents: write # Required to create releases
14+
pull-requests: read # Required to read PR metadata
1515
uses: github-community-projects/ospo-reusable-workflows/.github/workflows/release.yaml@3b691dff6b68489c8548e1295d125c93c9c29a4e
1616
with:
1717
publish: true
@@ -21,10 +21,10 @@ jobs:
2121
release_image:
2222
needs: release
2323
permissions:
24-
contents: read
25-
packages: write
26-
id-token: write
27-
attestations: write
24+
contents: read # Required to read repository contents
25+
packages: write # Required to publish container images
26+
id-token: write # Required for OIDC token signing
27+
attestations: write # Required to create build attestations
2828
uses: github-community-projects/ospo-reusable-workflows/.github/workflows/release-image.yaml@3b691dff6b68489c8548e1295d125c93c9c29a4e
2929
with:
3030
image-name: ${{ github.repository }}
@@ -38,8 +38,8 @@ jobs:
3838
release_discussion:
3939
needs: release
4040
permissions:
41-
contents: read
42-
discussions: write
41+
contents: read # Required to read repository contents
42+
discussions: write # Required to create release discussions
4343
uses: github-community-projects/ospo-reusable-workflows/.github/workflows/release-discussion.yaml@3b691dff6b68489c8548e1295d125c93c9c29a4e
4444
with:
4545
full-tag: ${{ needs.release.outputs.full-tag }}

0 commit comments

Comments
 (0)