Commit abfb8e6
committed
fix: correct parameter order and type annotations in get_github_app_installation_token
## What
Fixed swapped parameter order in test_get_github_app_installation_token where
gh_app_private_key_bytes and gh_app_id were in the wrong positions. Updated type
annotations for gh_app_id and gh_app_installation_id from str to int | None to
match the actual types returned by get_int_env_var and passed by callers.
## Why
The test passed despite the swapped arguments because create_jwt_headers was
mocked, so the incorrect types were never exercised. The str type annotations
were inconsistent with auth_to_github (which already used int | None) and with
config.py where these values originate as int | None from get_int_env_var.
## Notes
- Added str() cast at the create_jwt_headers call site, matching the existing
pattern in auth_to_github line 36
Signed-off-by: jmeridth <jmeridth@gmail.com>1 parent 013faea commit abfb8e6
2 files changed
Lines changed: 8 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | | - | |
| 64 | + | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
0 commit comments