Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of the created_at attribute for two different issue types by applying conditional logic based on the type.
- Updated markdown tests to include the created_at column in the output.
- Added a new configuration key "HIDE_CREATED_AT" to control the display of created_at.
- Modified issue metrics computation to differentiate between dict and github3.search.IssueSearchResult types using conditional logic.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test_markdown_writer.py | Added created_at parameter in tests and updated markdown table. |
| test_config.py | Added "HIDE_CREATED_AT" to the list of configuration keys. |
| issue_metrics.py | Introduced conditional logic to handle created_at from different types. |
| test_issue_metrics.py | Updated test dictionaries and config to support created_at handling. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
d2eafd9 to
0f60776
Compare
Fixes #489 We union dict and github3.search.IssueSearchResult types but their created at attributes are accessed differently. issue["createdAt"] for dict issue.issue.created_at for github3.search.IssueSearchResult - [x] turned off HIDE_CREATED_AT on some tests to ensure we are handling that scenario Signed-off-by: jmeridth <jmeridth@gmail.com>
0f60776 to
be847c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489
We union dict and github3.search.IssueSearchResult types but their created at attributes are accessed differently.
issue["createdAt"] for dict
issue.issue.created_at for github3.search.IssueSearchResult
Pull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking