Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the created_at attribute is included in the JSON output for issues. The changes update both the JSON writer function and its corresponding tests.
- Added the created_at field to the JSON output in json_writer.py.
- Updated test_json_writer.py to include created_at in input test cases and expected outputs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_json_writer.py | Added created_at parameter in issue objects and expected JSON. |
| json_writer.py | Updated JSON output to include the created_at field. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
- [x] update git version installed in image Signed-off-by: jmeridth <jmeridth@gmail.com>
d317f24 to
fa5f0ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional fixes for #489
created_atPull Request
Proposed Changes
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking