fix: address PR review feedback

## What/Why

Address reviewer feedback on PR #118: remove custom retry/timeout
constants in favor of PyGithub defaults, sanitize trailing slashes on
GHE URLs, fix unnecessary split/rejoin patterns for get_repo() calls,
and correct docstring/comment references.

## Proof it works

All 283 tests pass. Pylint shows only pre-existing warnings.

## Risk + AI role

Low -- cleanup changes only. AI-assisted (Claude Opus 4.6).

## Review focus

- auth.py retry/timeout removal: verify PyGithub defaults are acceptable
- ghe.rstrip("/") placement in both auth functions

Signed-off-by: jmeridth <jmeridth@gmail.com>

Author: jmeridth

auth.py

@@ -1,16 +1,6 @@
 """This is the module that contains functions related to authenticating to GitHub with a personal access token."""
 
 from github import Auth, Github, GithubIntegration
-from urllib3.util.retry import Retry
-
-# Retry strategy: 5 retries with exponential backoff for transient errors
-RETRY_STRATEGY = Retry(
-    total=5,
-    backoff_factor=1,  # 1s, 2s, 4s, 8s, 16s
-    status_forcelist=[429, 500, 502, 503, 504],
-    raise_on_status=False,
-)
-REQUEST_TIMEOUT = 30  # seconds
 
 
 def auth_to_github(
@@ -35,35 +25,25 @@ def auth_to_github(
     Returns:
         Github: the GitHub connection object
     """
+    ghe = ghe.rstrip("/")
+
     if gh_app_id and gh_app_private_key_bytes and gh_app_installation_id:
         app_auth = Auth.AppAuth(int(gh_app_id), gh_app_private_key_bytes.decode())
         installation_auth = app_auth.get_installation_auth(int(gh_app_installation_id))
         if ghe and gh_app_enterprise_only:
             github_connection = Github(
                 base_url=f"{ghe}/api/v3",
                 auth=installation_auth,
-                retry=RETRY_STRATEGY,
-                timeout=REQUEST_TIMEOUT,
             )
         else:
-            github_connection = Github(
-                auth=installation_auth,
-                retry=RETRY_STRATEGY,
-                timeout=REQUEST_TIMEOUT,
-            )
+            github_connection = Github(auth=installation_auth)
     elif ghe and token:
         github_connection = Github(
             base_url=f"{ghe}/api/v3",
             auth=Auth.Token(token),
-            retry=RETRY_STRATEGY,
-            timeout=REQUEST_TIMEOUT,
         )
     elif token:
-        github_connection = Github(
-            auth=Auth.Token(token),
-            retry=RETRY_STRATEGY,
-            timeout=REQUEST_TIMEOUT,
-        )
+        github_connection = Github(auth=Auth.Token(token))
     else:
         raise ValueError(
             "GH_TOKEN or the set of [GH_APP_ID, GH_APP_INSTALLATION_ID, "
@@ -93,6 +73,7 @@ def get_github_app_installation_token(
         str: the GitHub App token
     """
     try:
+        ghe = ghe.rstrip("/")
         app_auth = Auth.AppAuth(int(gh_app_id), gh_app_private_key_bytes.decode())
         if ghe:
             gi = GithubIntegration(auth=app_auth, base_url=f"{ghe}/api/v3")

pr_comment.py

@@ -70,8 +70,7 @@ def post_pr_comments(
 
     for repo_name in all_repo_names:
         conflicts = all_conflicts_by_repo.get(repo_name, [])
-        owner, repo = repo_name.split("/")
-        repo_obj = github_connection.get_repo(f"{owner}/{repo}")
+        repo_obj = github_connection.get_repo(repo_name)
 
         # Group active conflicts by PR
         pr_conflicts = group_conflicts_by_pr(conflicts) if conflicts else {}

pr_conflict_detector.py

@@ -217,8 +217,7 @@ def main():
         print("Report issue creation disabled (ENABLE_REPORT_ISSUES=false)")
     elif not env_vars.dry_run:
         for repo_full_name, conflicts in all_conflicts.items():
-            owner, rname = repo_full_name.split("/")
-            repo_obj = github_connection.get_repo(f"{owner}/{rname}")
+            repo_obj = github_connection.get_repo(repo_full_name)
             issue_url = create_or_update_issue(
                 repo_obj, conflicts, env_vars.report_title, env_vars.dry_run
             )
@@ -284,8 +283,7 @@ def get_repos_iterator(github_connection, env_vars):
 
     repos = []
     for repo_full_name in env_vars.repository_list:
-        owner, repo_name = repo_full_name.split("/")
-        repos.append(github_connection.get_repo(f"{owner}/{repo_name}"))
+        repos.append(github_connection.get_repo(repo_full_name))
     return repos
 
 

pr_data.py

@@ -97,7 +97,7 @@ def get_pr_changed_files(  # pylint: disable=unused-argument
     """
     Fetch the list of changed files for a given pull request.
 
-    Uses the PyGithub pull request's files() method, then parses
+    Uses the PyGithub pull request's get_files() method, then parses
     each file's patch to extract modified line ranges.
 
     Args:
@@ -171,7 +171,7 @@ def fetch_all_pr_data(
             print(f"  Progress: {i + 1}/{total} PRs processed")
 
         try:
-            # Re-fetch the full PR object to call files()
+            # Re-fetch the full PR object to call get_files()
             full_pr = repo.get_pull(pr_data.number)  # type: ignore[attr-defined]
             pr_data.changed_files = get_pr_changed_files(
                 full_pr, github_connection, owner, repo_name