Skip to content

chore: upgrade octokit to v5 and probot to v14 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Miablo merged 21 commits into from
Jun 26, 2026
Merged

chore: upgrade octokit to v5 and probot to v14 #484

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
0215d68
chore: upgrade octokit to v5 and probot to 14.3.2
Miablo May 21, 2026
49eb948
chore: update deps due to next-auth dep issue
Miablo May 21, 2026
7c80e6d
chore: update deps due to next-auth dep issue
Miablo May 21, 2026
7376e4d
chore: add comments to files for as any
Miablo Jun 11, 2026
b5c8e84
chore: fix lint issues
Miablo Jun 15, 2026
ce95f23
Update controller.ts
Miablo Jun 19, 2026
3e50d3d
Update controller.ts
Miablo Jun 19, 2026
458ae2a
Update controller.ts
Miablo Jun 19, 2026
dc021f5
Update webhooks.ts
Miablo Jun 19, 2026
d654302
Update webhooks.ts
Miablo Jun 19, 2026
04c340b
Update rules.ts
Miablo Jun 19, 2026
cd8e60c
Update rules.ts
Miablo Jun 19, 2026
7eafc0c
Update rules.ts
Miablo Jun 19, 2026
aae4f9a
chore: address PR 484 review feedback
Miablo Jun 22, 2026
4dd57dc
chore: merge upstream main changes into controller.ts
Miablo Jun 22, 2026
0404845
chore: merge main into feat/update-octokit-review-fixes to resolve co…
Miablo Jun 22, 2026
666ab93
chore: sync upstream non-version changes to resolve PR conflicts
Miablo Jun 22, 2026
3ceb352
Merge branch 'main' into another-miablo-octokit
Miablo Jun 22, 2026
f2d9d4c
chore: fix merge conflicts and tests
Miablo Jun 22, 2026
8756e3a
chore: fix unknown type err
Miablo Jun 22, 2026
f801119
chore: remove extra tsconfig
Miablo Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ build
!.env.example
.DS_Store
next-env.d.ts
*.tsbuildinfo
19,647 changes: 10,814 additions & 8,833 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@
"prepare": "husky || true"
},
"dependencies": {
"@octokit/auth-app": "6.1.1",
"@octokit/auth-app": "^7.1.5",
"@octokit/graphql-schema": "15.26.0",
"@primer/octicons-react": "19.15.2",
"@primer/react": "36.27.0",
"@probot/octokit-plugin-config": "^4.0.0",
"@t3-oss/env-nextjs": "0.13.7",
"@tanstack/react-query": "4.36.1",
"@trpc/client": "10.45.3",
Expand All @@ -34,9 +35,9 @@
"fast-safe-stringify": "2.1.1",
"fuse.js": "7.1.0",
"next": "16.2.6",
"next-auth": "4.24.12",
"octokit": "3.2.2",
"probot": "13.4.7",
"next-auth": "4.24.14",
"octokit": "^5.0.5",
"probot": "14.3.2",
"proxy-agent": "6.5.0",
"react": "18.3.1",
"react-dom": "18.3.1",
Expand All @@ -50,6 +51,7 @@
},
"devDependencies": {
"@eslint/js": "9.39.2",
"@octokit/openapi-webhooks-types-transition": "^12.1.0",
"@tanstack/eslint-plugin-query": "5.78.0",
"@tsconfig/next": "^2.0.6",
"@types/node": "^22.19.15",
Expand Down
192 changes: 106 additions & 86 deletions src/app/[organizationId]/forks/[forkId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ const Fork = () => {
})

// perform search if there is a search value
let mirrorSet = []
let mirrorSet: typeof mirrors = []
if (searchValue) {
mirrorSet = fuse.search(searchValue).map((result) => result.item)
} else {
Expand Down Expand Up @@ -566,94 +566,114 @@ const Fork = () => {
<DataTable
aria-describedby="mirrors table"
aria-labelledby="mirrors table"
data={mirrorPaginationSet}
columns={[
{
header: 'Mirror name',
rowHeader: true,
field: 'name',
sortBy: 'alphanumeric',
width: '400px',
renderCell: (row) => {
return (
<Link
sx={{
paddingRight: '5px',
fontWeight: 'bold',
fontSize: 2,
}}
href={row.html_url}
target="_blank"
rel="noreferrer noopener"
>
{row.name}
</Link>
)
data={
mirrorPaginationSet as Array<{
id: number
name: string
html_url: string
updated_at: string
}>
}
// `satisfies` cannot be used here — the issue is that under moduleResolution:"bundler", DataTable's
// generic Data param isn't inferred from the data prop and falls back to UniqueRow, making `field`
// only accept "id". `satisfies` would still error on field:"name" etc. `as any` is the only workaround
// until @primer/react fixes DataTable generic inference (draft component).
columns={
[
{
header: 'Mirror name',
rowHeader: true,
field: 'name',
sortBy: 'alphanumeric',
width: '400px',
// eslint-disable-next-line @typescript-eslint/no-explicit-any
renderCell: (row: any) => {
return (
<Link
sx={{
paddingRight: '5px',
fontWeight: 'bold',
fontSize: 2,
}}
href={row.html_url}
target="_blank"
rel="noreferrer noopener"
>
{row.name}
</Link>
)
},
},
},
{
header: 'Last updated',
field: 'updated_at',
sortBy: 'datetime',
width: 'auto',
renderCell: (row) => {
return (
<RelativeTime date={new Date(row.updated_at)} tense="past" />
)
{
header: 'Last updated',
field: 'updated_at',
sortBy: 'datetime',
width: 'auto',
// eslint-disable-next-line @typescript-eslint/no-explicit-any
renderCell: (row: any) => {
return (
<RelativeTime
date={new Date(row.updated_at)}
tense="past"
/>
)
},
},
},
{
id: 'actions',
header: '',
width: '50px',
align: 'end',
renderCell: (row) => {
return (
<ActionMenu>
<ActionMenu.Anchor>
<IconButton
aria-label={`Actions: ${row.name}`}
icon={KebabHorizontalIcon}
variant="invisible"
/>
</ActionMenu.Anchor>
<ActionMenu.Overlay>
<ActionList>
<ActionList.Item
onSelect={() => {
openEditDialog(row.name)
}}
>
<Stack align="center" direction="horizontal">
<Stack.Item>
<Octicon icon={PencilIcon}></Octicon>
</Stack.Item>
<Stack.Item>Edit mirror</Stack.Item>
</Stack>
</ActionList.Item>
<ActionList.Item
variant="danger"
onSelect={() => {
openDeleteDialog(
row.name,
mirrorPaginationSet.length,
)
}}
>
<Stack align="center" direction="horizontal">
<Stack.Item>
<Octicon icon={TrashIcon}></Octicon>
</Stack.Item>
<Stack.Item>Delete mirror</Stack.Item>
</Stack>
</ActionList.Item>
</ActionList>
</ActionMenu.Overlay>
</ActionMenu>
)
{
id: 'actions',
header: '',
width: '50px',
align: 'end',
// eslint-disable-next-line @typescript-eslint/no-explicit-any
renderCell: (row: any) => {
return (
<ActionMenu>
<ActionMenu.Anchor>
<IconButton
aria-label={`Actions: ${row.name}`}
icon={KebabHorizontalIcon}
variant="invisible"
/>
</ActionMenu.Anchor>
<ActionMenu.Overlay>
<ActionList>
<ActionList.Item
onSelect={() => {
openEditDialog(row.name)
}}
>
<Stack align="center" direction="horizontal">
<Stack.Item>
<Octicon icon={PencilIcon}></Octicon>
</Stack.Item>
<Stack.Item>Edit mirror</Stack.Item>
</Stack>
</ActionList.Item>
<ActionList.Item
variant="danger"
onSelect={() => {
openDeleteDialog(
row.name,
mirrorPaginationSet.length,
)
}}
>
<Stack align="center" direction="horizontal">
<Stack.Item>
<Octicon icon={TrashIcon}></Octicon>
</Stack.Item>
<Stack.Item>Delete mirror</Stack.Item>
</Stack>
</ActionList.Item>
</ActionList>
</ActionMenu.Overlay>
</ActionMenu>
)
},
},
},
]}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
] as any
}
cellPadding="spacious"
/>
<Table.Pagination
Expand Down
Loading
Loading