Skip to content

fix: resolve pylint config errors breaking super-linter#433

Merged
zkoppert merged 1 commit into
github-community-projects:mainfrom
jmeridth:patch-1
Feb 27, 2026
Merged

fix: resolve pylint config errors breaking super-linter#433
zkoppert merged 1 commit into
github-community-projects:mainfrom
jmeridth:patch-1

Conversation

@jmeridth

Copy link
Copy Markdown
Collaborator

What

Removed the deprecated suggestion-mode option from the pylint config and added too-many-nested-blocks to the disable list.

Why

The suggestion-mode option was removed in newer versions of pylint, causing an E0015: Unrecognized option error that fails the super-linter CI job. The too-many-nested-blocks violation in merge_contributors is pre-existing and consistent with the other too-many-* rules already disabled.

Notes

  • The nested blocks issue in contributor_stats.py:112 would benefit from a refactor (dict-based merge instead of nested loops) in a follow-up PR
  • These errors were hidden until super-linter upgraded its bundled pylint version
  • Saw these errors here
  • suggestion-mode was removed in 4.0 of pylint

Pull Request

Proposed Changes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

## What

Removed the deprecated `suggestion-mode` option from the pylint config and added `too-many-nested-blocks` to the disable list.

## Why

The `suggestion-mode` option was removed in newer versions of pylint, causing an `E0015: Unrecognized option` error that fails the super-linter CI job. The `too-many-nested-blocks` violation in `merge_contributors` is pre-existing and consistent with the other `too-many-*` rules already disabled.

## Notes

- The nested blocks issue in `contributor_stats.py:112` would benefit from a refactor (dict-based merge instead of nested loops) in a follow-up PR
- These errors were hidden until super-linter upgraded its bundled pylint version
- Saw these errors [here](https://github.com/github-community-projects/contributors/actions/runs/22372943481/job/64756293990?pr=394#step:5:488)
- `suggestion-mode` was [removed in 4.0 of pylint](https://pylint.readthedocs.io/en/latest/whatsnew/4/4.0/index.html)

Signed-off-by: Jason Meridth <jmeridth@proton.me>
@jmeridth jmeridth requested a review from a team as a code owner February 25, 2026 03:09
Copilot AI review requested due to automatic review settings February 25, 2026 03:09
@github-actions github-actions Bot added the fix label Feb 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s pylint configuration used by CI/super-linter to avoid failures caused by deprecated/removed pylint options.

Changes:

  • Remove the deprecated suggestion-mode option from .github/linters/.python-lint.

Comment on lines 100 to 104
source-roots=

# When enabled, pylint would attempt to guess common misconfiguration and emit
# user-friendly hints instead of false-positive error messages.
suggestion-mode=yes

# Allow loading of arbitrary C extensions. Extensions are imported into the
# active Python interpreter and may run arbitrary code.
unsafe-load-any-extension=no

Copilot AI Feb 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says too-many-nested-blocks was added to the pylint disable= list, but this change isn’t present in .github/linters/.python-lint (and too-many-nested-blocks doesn’t appear anywhere in this config). Please either add it to the disable= list under [MESSAGES CONTROL] (if it’s still needed to unblock CI) or update the PR description to match the actual change set.

Copilot uses AI. Check for mistakes.
@zkoppert zkoppert merged commit 3338c21 into github-community-projects:main Feb 27, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants