refactor: migrate from sqlite3 to better-sqlite3 for improved performance and simplicity

- Updated package.json files to replace sqlite3 with better-sqlite3 in shared and web packages.
- Refactored sqlite-storage.ts to utilize better-sqlite3 API, simplifying database operations and initialization.
- Adjusted test-database.ts to accommodate changes in database handling with better-sqlite3.
- Modified tests in sqlite-storage.test.ts to mock better-sqlite3 instead of sqlite3.
- Updated next-env.d.ts to reference the correct types for Next.js.

Author: chrisreddington

package-lock.json

@@ -18,8 +18,8 @@
     "test": "npm run test --workspace=shared && npm run test --workspace=web && npm run test --workspace=mcp-server",
     "test:watch": "npm run test:watch --workspace=shared",
     "test:coverage": "npm run test:coverage --workspace=shared && npm run test:coverage --workspace=web && npm run test:coverage --workspace=mcp-server",
-    "lint": "eslint .",
-    "lint:fix": "eslint . --fix",
+    "lint": "npm run lint --workspace=shared && npm run lint --workspace=web && npm run lint --workspace=mcp-server",
+    "lint:fix": "npm run lint:fix --workspace=shared && npm run lint:fix --workspace=web && npm run lint:fix --workspace=mcp-server",
     "lint:all": "npm run lint --workspace=shared && npm run lint --workspace=web && npm run lint --workspace=mcp-server",
     "ci:tests": "npm run test --workspace=@turn-based-mcp/shared && npm run test --workspace=@turn-based-mcp/web && npm run test --workspace=@turn-based-mcp/mcp-server",
     "ci": "npm run build --workspace=@turn-based-mcp/shared && npm run type-check && npm run build --workspace=@turn-based-mcp/web && npm run build --workspace=@turn-based-mcp/mcp-server && npm run ci:tests && npm run lint --workspace=@turn-based-mcp/web"

package.json

@@ -44,6 +44,9 @@
     "vitest": "^4.0.18"
   },
   "dependencies": {
-    "sqlite3": "^5.1.7"
+    "better-sqlite3": "^12.6.2"
+  },
+  "optionalDependencies": {
+    "@types/better-sqlite3": "^7.6.13"
   }
 }

shared/package.json

@@ -1,34 +1,24 @@
 import { vi } from 'vitest'
 import * as sqliteStorage from './sqlite-storage';
 
-// Mock sqlite3 to prevent actual database operations
+// Mock better-sqlite3 to prevent actual database operations
 // In vitest v4, mocks used as constructors must use 'function' or 'class' syntax
-vi.mock('sqlite3', () => ({
-  default: {
-    Database: vi.fn(function() {
+vi.mock('better-sqlite3', () => {
+  const mockStatement = {
+    run: vi.fn(() => ({ lastInsertRowid: 1, changes: 1 })),
+    get: vi.fn(() => undefined),
+    all: vi.fn(() => []),
+  }
+  return {
+    default: vi.fn(function() {
       return {
-        run: vi.fn(function(sql: string, params: unknown, callback?: (this: { lastID: number; changes: number }) => void) {
-          if (callback) {
-            // Mock the 'this' context with lastID and changes
-            callback.call({ lastID: 1, changes: 1 });
-          }
-        }),
-        get: vi.fn((sql: string, params: unknown, callback?: (err: Error | null, row: unknown) => void) => {
-          if (callback) callback(null, null);
-        }),
-        all: vi.fn((sql: string, params: unknown, callback?: (err: Error | null, rows: unknown[]) => void) => {
-          if (callback) callback(null, []);
-        }),
-        close: vi.fn((callback?: () => void) => {
-          if (callback) callback();
-        }),
-        serialize: vi.fn((fn?: () => void) => {
-          if (fn) fn();
-        })
-      };
+        prepare: vi.fn(() => mockStatement),
+        exec: vi.fn(),
+        close: vi.fn(),
+      }
     })
   }
-}));
+});
 
 // Integration-style tests for SQLite storage
 // These tests verify the public API without heavy mocking