Use GFM note alert, WCAG 2.2, and core.getBooleanInput

Author: kzhou314

.github/actions/file/src/generateIssueBody.ts

@@ -20,15 +20,15 @@ export function generateIssueBody(finding: Finding, screenshotRepo: string): str
 
   const categoryNotice =
     finding.category && finding.category !== 'wcag'
-      ? `**Note:** This is ${
+      ? `> [!NOTE]\n> This is ${
           finding.category === 'experimental' ? 'an experimental check' : 'a best-practice recommendation'
         }, not a definite WCAG failure.\n\n`
       : ''
 
   const standardsLine =
     finding.category && finding.category !== 'wcag'
-      ? '- [ ] The fix MUST meet the accessibility standards specified by the repository or organization (WCAG 2.1 if applicable).'
-      : '- [ ] The fix MUST meet WCAG 2.1 guidelines OR the accessibility standards specified by the repository or organization.'
+      ? '- [ ] The fix MUST meet the accessibility standards specified by the repository or organization (WCAG 2.2 if applicable).'
+      : '- [ ] The fix MUST meet WCAG 2.2 guidelines OR the accessibility standards specified by the repository or organization.'
 
   const acceptanceCriteria = `## Acceptance Criteria
 - [ ] The specific violation reported in this issue is no longer reproducible.

.github/actions/file/src/index.ts

@@ -16,15 +16,10 @@ import {updateFilingsWithNewFindings} from './updateFilingsWithNewFindings.js'
 import {OctokitResponse} from '@octokit/types'
 const OctokitWithThrottling = Octokit.plugin(throttling)
 
-// Throws when an input is unset, so this defaults unset
-// switches while still rejecting values that aren't a valid boolean.
+// core.getBooleanInput throws on unset inputs, so apply the default first.
 function getBooleanInputWithDefault(name: string, defaultValue: boolean): boolean {
-  const raw = core.getInput(name)
-  if (!raw) return defaultValue
-  const normalized = raw.trim().toLowerCase()
-  if (normalized === 'true') return true
-  if (normalized === 'false') return false
-  throw new TypeError(`Invalid boolean input '${name}': '${raw}'. Expected 'true' or 'false'.`)
+  if (!core.getInput(name)) return defaultValue
+  return core.getBooleanInput(name)
 }
 
 export default async function () {

.github/actions/file/tests/generateIssueBody.test.ts

@@ -26,7 +26,7 @@ describe('generateIssueBody', () => {
     expect(body).toContain('## What')
     expect(body).toContain('## Acceptance Criteria')
     expect(body).toContain('The specific violation reported in this issue is no longer reproducible.')
-    expect(body).toContain('The fix MUST meet WCAG 2.1 guidelines OR')
+    expect(body).toContain('The fix MUST meet WCAG 2.2 guidelines OR')
     expect(body).not.toContain('Specifically:')
   })
 
@@ -79,29 +79,29 @@ describe('generateIssueBody', () => {
   })
 
   it('omits the category notice for WCAG findings', () => {
-    expect(generateIssueBody(baseFinding, 'github/accessibility-scanner')).not.toContain('**Note:**')
+    expect(generateIssueBody(baseFinding, 'github/accessibility-scanner')).not.toContain('> [!NOTE]')
     expect(generateIssueBody({...baseFinding, category: 'wcag'}, 'github/accessibility-scanner')).not.toContain(
-      '**Note:**',
+      '> [!NOTE]',
     )
   })
 
   it('includes a best-practice notice for best-practice findings', () => {
     const body = generateIssueBody({...baseFinding, category: 'best-practice'}, 'github/accessibility-scanner')
 
-    expect(body).toContain('**Note:**')
+    expect(body).toContain('> [!NOTE]')
     expect(body).toContain('best-practice recommendation')
-    expect(body).toContain('not a hard WCAG failure')
-    expect(body).toContain('WCAG 2.1 if applicable')
-    expect(body).not.toContain('The fix MUST meet WCAG 2.1 guidelines OR')
+    expect(body).toContain('not a definite WCAG failure')
+    expect(body).toContain('WCAG 2.2 if applicable')
+    expect(body).not.toContain('The fix MUST meet WCAG 2.2 guidelines OR')
   })
 
   it('includes an experimental notice for experimental findings', () => {
     const body = generateIssueBody({...baseFinding, category: 'experimental'}, 'github/accessibility-scanner')
 
-    expect(body).toContain('**Note:**')
+    expect(body).toContain('> [!NOTE]')
     expect(body).toContain('an experimental check')
-    expect(body).toContain('not a hard WCAG failure')
-    expect(body).toContain('WCAG 2.1 if applicable')
-    expect(body).not.toContain('The fix MUST meet WCAG 2.1 guidelines OR')
+    expect(body).toContain('not a definite WCAG failure')
+    expect(body).toContain('WCAG 2.2 if applicable')
+    expect(body).not.toContain('The fix MUST meet WCAG 2.2 guidelines OR')
   })
 })