Address Copilot feedback on input validation and acceptance criteria

Author: kzhou314

.github/actions/file/src/generateIssueBody.ts

@@ -25,9 +25,14 @@ export function generateIssueBody(finding: Finding, screenshotRepo: string): str
         }, not a hard WCAG failure.\n\n`
       : ''
 
+  const standardsLine =
+    finding.category && finding.category !== 'wcag'
+      ? '- [ ] The fix MUST meet the accessibility standards specified by the repository or organization (WCAG 2.1 if applicable).'
+      : '- [ ] The fix MUST meet WCAG 2.1 guidelines OR the accessibility standards specified by the repository or organization.'
+
   const acceptanceCriteria = `## Acceptance Criteria
 - [ ] The specific violation reported in this issue is no longer reproducible.
-- [ ] The fix MUST meet WCAG 2.1 guidelines OR the accessibility standards specified by the repository or organization.
+${standardsLine}
 - [ ] A test SHOULD be added to ensure this specific violation does not regress.
 - [ ] This PR MUST NOT introduce any new accessibility issues or regressions.`
 

.github/actions/file/src/index.ts

@@ -16,11 +16,15 @@ import {updateFilingsWithNewFindings} from './updateFilingsWithNewFindings.js'
 import {OctokitResponse} from '@octokit/types'
 const OctokitWithThrottling = Octokit.plugin(throttling)
 
-// core.getBooleanInput throws when an input is missing, so default unset switches.
+// core.getBooleanInput throws when an input is unset, so this defaults unset
+// switches while still rejecting values that aren't a valid boolean.
 function getBooleanInputWithDefault(name: string, defaultValue: boolean): boolean {
   const raw = core.getInput(name)
   if (!raw) return defaultValue
-  return raw.toLowerCase() === 'true'
+  const normalized = raw.trim().toLowerCase()
+  if (normalized === 'true') return true
+  if (normalized === 'false') return false
+  throw new TypeError(`Invalid boolean input '${name}': '${raw}'. Expected 'true' or 'false'.`)
 }
 
 export default async function () {

.github/actions/file/tests/generateIssueBody.test.ts

@@ -26,6 +26,7 @@ describe('generateIssueBody', () => {
     expect(body).toContain('## What')
     expect(body).toContain('## Acceptance Criteria')
     expect(body).toContain('The specific violation reported in this issue is no longer reproducible.')
+    expect(body).toContain('The fix MUST meet WCAG 2.1 guidelines OR')
     expect(body).not.toContain('Specifically:')
   })
 
@@ -90,6 +91,8 @@ describe('generateIssueBody', () => {
     expect(body).toContain('**Note:**')
     expect(body).toContain('best-practice recommendation')
     expect(body).toContain('not a hard WCAG failure')
+    expect(body).toContain('WCAG 2.1 if applicable')
+    expect(body).not.toContain('The fix MUST meet WCAG 2.1 guidelines OR')
   })
 
   it('includes an experimental notice for experimental findings', () => {
@@ -98,5 +101,7 @@ describe('generateIssueBody', () => {
     expect(body).toContain('**Note:**')
     expect(body).toContain('an experimental check')
     expect(body).toContain('not a hard WCAG failure')
+    expect(body).toContain('WCAG 2.1 if applicable')
+    expect(body).not.toContain('The fix MUST meet WCAG 2.1 guidelines OR')
   })
 })