Skip to content

Commit b61d801

Browse files
taarikashenafiCopilotJoyceZhu
authored
Apply suggestions from code review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joyce Zhu <joycezhu@github.com>
1 parent 34581d4 commit b61d801

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

.github/actions/file/src/generateIssueBody.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function generateIssueBody(findingOrFindings: Finding | Finding[], screen
2525
if (findings.length > 1) {
2626
const items = findings.map(f => `- [ ] ${f.html ? `\`${f.html}\` on ${f.url}` : f.url}`).join('\n')
2727
occurrencesSection = `
28-
## Occurrences (${findings.length})
28+
## ${findings.length} Other Occurrences:
2929
3030
${items}
3131
`

.github/actions/file/src/updateFilingsWithNewFindings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ function getFilingKey(filing: ResolvedFiling | RepeatedFiling): string {
55
}
66

77
function getFindingKey(finding: Finding, groupBy: GroupBy): string {
8-
const rule = finding.ruleId ?? `${finding.scannerType};${finding.problemUrl}`
8+
const rule = finding.ruleId ? `${finding.scannerType};${finding.ruleId}` : `${finding.scannerType};${finding.problemUrl}`
99

1010
switch (groupBy) {
1111
case 'rule':

0 commit comments

Comments
 (0)