Skip to content

Commit c1cf4d0

Browse files
Remove comments
1 parent 35ebacb commit c1cf4d0

2 files changed

Lines changed: 1 addition & 10 deletions

File tree

.github/actions/file/src/generateIssueBody.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export function generateIssueBody(findingOrFindings: Finding | Finding[], screen
2121
`
2222
}
2323

24-
// When this issue groups multiple findings, list each occurrence as a checklist item.
2524
let occurrencesSection = ''
2625
if (findings.length > 1) {
2726
const items = findings.map(f => `- [ ] ${f.html ? `\`${f.html}\` on ${f.url}` : f.url}`).join('\n')

.github/actions/file/src/updateFilingsWithNewFindings.ts

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ function getFilingKey(filing: ResolvedFiling | RepeatedFiling): string {
44
return filing.issue.url
55
}
66

7-
/**
8-
* Computes the dedup key for a finding based on the grouping mode.
9-
* - 'finding' (default): one filing per individual violation (URL + rule + element).
10-
* - 'rule': one filing per rule, aggregating every occurrence across all URLs.
11-
* - 'rule+url': one filing per rule per scanned URL.
12-
*/
137
function getFindingKey(finding: Finding, groupBy: GroupBy): string {
148
const rule = finding.ruleId ?? `${finding.scannerType};${finding.problemUrl}`
159

@@ -54,13 +48,11 @@ export function updateFilingsWithNewFindings(
5448
const key = getFindingKey(finding, groupBy)
5549
const filingKey = findingKeys[key]
5650
if (filingKey) {
57-
// This finding already maps to an existing issue; append it to that filing
51+
// This finding already has an associated filing; add it to that filing's findings
5852
;(filingKeys[filingKey] as RepeatedFiling).findings.push(finding)
5953
} else if (newFilingKeys[key]) {
60-
// A new filing for this group already exists this run; append to it
6154
newFilingKeys[key].findings.push(finding)
6255
} else {
63-
// First occurrence of this group with no existing issue; start a new filing
6456
newFilingKeys[key] = {findings: [finding]}
6557
}
6658
}

0 commit comments

Comments
 (0)