Skip to content

Commit f669b4d

Browse files
CopilotJoyceZhu
Copilot
and
JoyceZhu
committed
Fix top-level @actions/core import in bootstrap.js files
Root cause: PR #143 added `import * as core from '@actions/core'` as a top-level static import. Since node_modules isn't pre-installed, Node.js fails to resolve this import before any code (including npm ci) runs. Fix: Replace the static top-level import with a dynamic import inside the `finally` block where node_modules is guaranteed to exist. For the npm ci failure case, use console.error since @actions/core isn't available yet. Co-authored-by: JoyceZhu <6251669+JoyceZhu@users.noreply.github.com>
1 parent 5396dcb commit f669b4d

5 files changed

Lines changed: 63 additions & 52 deletions

File tree

‎.github/actions/auth/bootstrap.js‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33

44
import fs from 'node:fs'
55
import * as url from 'node:url'
6-
import { spawn } from 'node:child_process'
6+
import {spawn} from 'node:child_process'
77

8-
function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
8+
function spawnPromisified(command, args, {quiet = false, ...options} = {}) {
99
return new Promise((resolve, reject) => {
1010
const proc = spawn(command, args, options)
1111
proc.stdout.setEncoding('utf8')
12-
proc.stdout.on('data', (data) => {
12+
proc.stdout.on('data', data => {
1313
if (!quiet) {
1414
console.log(data)
1515
}
1616
})
1717
proc.stderr.setEncoding('utf8')
18-
proc.stderr.on('data', (data) => {
18+
proc.stderr.on('data', data => {
1919
console.error(data)
2020
})
21-
proc.on('close', (code) => {
21+
proc.on('close', code => {
2222
if (code !== 0) {
2323
reject(code)
2424
} else {
@@ -31,30 +31,31 @@ function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
3131
await (async () => {
3232
// If dependencies are not vendored-in, install them at runtime.
3333
try {
34-
await fs.accessSync(
35-
url.fileURLToPath(new URL('./node_modules', import.meta.url)),
36-
fs.constants.R_OK
37-
)
34+
await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
3835
} catch {
3936
try {
4037
await spawnPromisified('npm', ['ci'], {
4138
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
42-
quiet: true
39+
quiet: true,
4340
})
44-
} catch {
41+
} catch (error) {
42+
console.error(`npm ci failed: ${error}`)
4543
process.exit(1)
4644
}
4745
} finally {
46+
const core = await import('@actions/core')
4847
// Compile TypeScript.
4948
try {
5049
await spawnPromisified('npm', ['run', 'build'], {
5150
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
52-
quiet: true
51+
quiet: true,
5352
})
54-
} catch {
53+
} catch (error) {
54+
core.setFailed(`npm run build (TypeScript compilation) failed: ${error}`)
5555
process.exit(1)
5656
}
5757
// Run the main script.
58+
core.info('Running auth Action index.js...')
5859
const action = await import('./dist/index.js')
5960
await action.default()
6061
}

‎.github/actions/file/bootstrap.js‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33

44
import fs from 'node:fs'
55
import * as url from 'node:url'
6-
import { spawn } from 'node:child_process'
6+
import {spawn} from 'node:child_process'
77

8-
function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
8+
function spawnPromisified(command, args, {quiet = false, ...options} = {}) {
99
return new Promise((resolve, reject) => {
1010
const proc = spawn(command, args, options)
1111
proc.stdout.setEncoding('utf8')
12-
proc.stdout.on('data', (data) => {
12+
proc.stdout.on('data', data => {
1313
if (!quiet) {
1414
console.log(data)
1515
}
1616
})
1717
proc.stderr.setEncoding('utf8')
18-
proc.stderr.on('data', (data) => {
18+
proc.stderr.on('data', data => {
1919
console.error(data)
2020
})
21-
proc.on('close', (code) => {
21+
proc.on('close', code => {
2222
if (code !== 0) {
2323
reject(code)
2424
} else {
@@ -31,30 +31,31 @@ function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
3131
await (async () => {
3232
// If dependencies are not vendored-in, install them at runtime.
3333
try {
34-
await fs.accessSync(
35-
url.fileURLToPath(new URL('./node_modules', import.meta.url)),
36-
fs.constants.R_OK
37-
)
34+
await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
3835
} catch {
3936
try {
4037
await spawnPromisified('npm', ['ci'], {
4138
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
42-
quiet: true
39+
quiet: true,
4340
})
44-
} catch {
41+
} catch (error) {
42+
console.error(`npm ci failed: ${error}`)
4543
process.exit(1)
4644
}
4745
} finally {
46+
const core = await import('@actions/core')
4847
// Compile TypeScript.
4948
try {
5049
await spawnPromisified('npm', ['run', 'build'], {
5150
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
52-
quiet: true
51+
quiet: true,
5352
})
54-
} catch {
53+
} catch (error) {
54+
core.setFailed(`npm run build (TypeScript compilation) failed: ${error}`)
5555
process.exit(1)
5656
}
5757
// Run the main script.
58+
core.info('Running file Action index.js...')
5859
const action = await import('./dist/index.js')
5960
await action.default()
6061
}

‎.github/actions/find/bootstrap.js‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33

44
import fs from 'node:fs'
55
import * as url from 'node:url'
6-
import { spawn } from 'node:child_process'
6+
import {spawn} from 'node:child_process'
77

8-
function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
8+
function spawnPromisified(command, args, {quiet = false, ...options} = {}) {
99
return new Promise((resolve, reject) => {
1010
const proc = spawn(command, args, options)
1111
proc.stdout.setEncoding('utf8')
12-
proc.stdout.on('data', (data) => {
12+
proc.stdout.on('data', data => {
1313
if (!quiet) {
1414
console.log(data)
1515
}
1616
})
1717
proc.stderr.setEncoding('utf8')
18-
proc.stderr.on('data', (data) => {
18+
proc.stderr.on('data', data => {
1919
console.error(data)
2020
})
21-
proc.on('close', (code) => {
21+
proc.on('close', code => {
2222
if (code !== 0) {
2323
reject(code)
2424
} else {
@@ -31,30 +31,31 @@ function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
3131
await (async () => {
3232
// If dependencies are not vendored-in, install them at runtime.
3333
try {
34-
await fs.accessSync(
35-
url.fileURLToPath(new URL('./node_modules', import.meta.url)),
36-
fs.constants.R_OK
37-
)
34+
await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
3835
} catch {
3936
try {
4037
await spawnPromisified('npm', ['ci'], {
4138
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
42-
quiet: true
39+
quiet: true,
4340
})
44-
} catch {
41+
} catch (error) {
42+
console.error(`npm ci failed: ${error}`)
4543
process.exit(1)
4644
}
4745
} finally {
46+
const core = await import('@actions/core')
4847
// Compile TypeScript.
4948
try {
5049
await spawnPromisified('npm', ['run', 'build'], {
5150
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
52-
quiet: true
51+
quiet: true,
5352
})
54-
} catch {
53+
} catch (error) {
54+
core.setFailed(`npm run build (TypeScript compilation) failed: ${error}`)
5555
process.exit(1)
5656
}
5757
// Run the main script.
58+
core.info('Running find Action index.js...')
5859
const action = await import('./dist/index.js')
5960
await action.default()
6061
}

‎.github/actions/fix/bootstrap.js‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33

44
import fs from 'node:fs'
55
import * as url from 'node:url'
6-
import { spawn } from 'node:child_process'
6+
import {spawn} from 'node:child_process'
77

8-
function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
8+
function spawnPromisified(command, args, {quiet = false, ...options} = {}) {
99
return new Promise((resolve, reject) => {
1010
const proc = spawn(command, args, options)
1111
proc.stdout.setEncoding('utf8')
12-
proc.stdout.on('data', (data) => {
12+
proc.stdout.on('data', data => {
1313
if (!quiet) {
1414
console.log(data)
1515
}
1616
})
1717
proc.stderr.setEncoding('utf8')
18-
proc.stderr.on('data', (data) => {
18+
proc.stderr.on('data', data => {
1919
console.error(data)
2020
})
21-
proc.on('close', (code) => {
21+
proc.on('close', code => {
2222
if (code !== 0) {
2323
reject(code)
2424
} else {
@@ -31,30 +31,31 @@ function spawnPromisified(command, args, { quiet = false, ...options } = {}) {
3131
await (async () => {
3232
// If dependencies are not vendored-in, install them at runtime.
3333
try {
34-
await fs.accessSync(
35-
url.fileURLToPath(new URL('./node_modules', import.meta.url)),
36-
fs.constants.R_OK
37-
)
34+
await fs.accessSync(url.fileURLToPath(new URL('./node_modules', import.meta.url)), fs.constants.R_OK)
3835
} catch {
3936
try {
4037
await spawnPromisified('npm', ['ci'], {
4138
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
42-
quiet: true
39+
quiet: true,
4340
})
44-
} catch {
41+
} catch (error) {
42+
console.error(`npm ci failed: ${error}`)
4543
process.exit(1)
4644
}
4745
} finally {
46+
const core = await import('@actions/core')
4847
// Compile TypeScript.
4948
try {
5049
await spawnPromisified('npm', ['run', 'build'], {
5150
cwd: url.fileURLToPath(new URL('.', import.meta.url)),
52-
quiet: true
51+
quiet: true,
5352
})
54-
} catch {
53+
} catch (error) {
54+
core.setFailed(`npm run build (TypeScript compilation) failed: ${error}`)
5555
process.exit(1)
5656
}
5757
// Run the main script.
58+
core.info('Running fix Action index.js...')
5859
const action = await import('./dist/index.js')
5960
await action.default()
6061
}

‎package-lock.json‎

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)