Update dependencies to resolve security findings#73
Closed
johan-j wants to merge 4 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Node/TypeScript action dependencies to address security findings (vuln-mgmt#181381) for this repository’s GitHub Action.
Changes:
- Bump
@actions/coreto^3.0.0and@actions/githubto^9.0.0. - Move build/type-only packages to
devDependenciesand update@github/local-actionto^7.0.1. - Remove
prettier-eslintfromdevDependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- eslint: Use __dirname for tsconfigRootDir (required by newer @typescript-eslint/parser) - jest: Add moduleNameMapper for pure ESM @actions packages - Rebuild dist/
action.yml was still using node16, which is incompatible with @actions/core@3, @actions/github@9, and openai@5 (all require Node >=18). The engines field in package.json already specifies >=20.
Regenerate .licenses/ cache after dependency version bumps. Removes stale records for old transitive deps and adds new ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Resolve security findings: dependency updates and cleanup
Summary
Updates production dependencies to address all 5 Dependabot security findings and removes an unused package that was pulling in vulnerable transitive dependencies. Reduces
npm auditfindings from 13 → 5 (the remaining 5 are in a devDependency awaiting an upstream fix).Security findings resolved
@actions/coreand@actions/github@github/local-action(resolves to 5.5.1)prettier-eslintDependency changes
@actions/core^2.0.2^3.0.0@actions/github^7.0.0^9.0.0@github/local-action^5.1.0^7.0.1prettier-eslint^16.4.2@rollup/plugin-json@types/js-yamlConfig fixes
tsconfigRootDir: '.'→tsconfigRootDir: __dirname(required by updated@typescript-eslint/parser)moduleNameMapperfor@actions/coreand@actions/github(pure ESM packages need explicit resolution forjest.mock())Remaining audit items
5 moderate-severity
undici@5.29.0findings remain inside@github/local-action@7.0.1→@actions/artifact→@actions/github@6.0.1(transitive). This is the latest available version of the package — requires an upstream fix. These are devDependencies only and are not shipped in the action bundle.Testing
npm run allpasses (format, lint, 22/22 tests, coverage, bundle)