Skip to content

Commit b017ed7

Browse files
authored
Merge pull request #42 from github/combobox
Upgrade combobox-nav to v2 for ARIA 1.2
2 parents 8f64602 + 21348b4 commit b017ed7

11 files changed

Lines changed: 777 additions & 301 deletions

File tree

.github/workflows/nodejs.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,12 @@ jobs:
99

1010
runs-on: ubuntu-latest
1111

12-
strategy:
13-
matrix:
14-
node-version: [8.x, 10.x, 12.x]
15-
1612
steps:
1713
- uses: actions/checkout@v1
18-
- name: Use Node.js ${{ matrix.node-version }}
14+
- name: Use Node.js 12.x
1915
uses: actions/setup-node@v1
2016
with:
21-
node-version: ${{ matrix.node-version }}
17+
node-version: '12.x'
2218
- name: npm install, build, and test
2319
run: |
2420
npm install

README.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,24 @@ $ npm install --save @github/auto-complete-element
1010

1111
## Usage
1212

13+
### Script
14+
15+
Import as ES modules:
16+
1317
```js
1418
import '@github/auto-complete-element'
1519
```
1620

21+
With a script tag:
22+
23+
```html
24+
<script type="module" src="./node_modules/@github/auto-complete-element/dist/bundle.js">
25+
```
26+
27+
### Markup
28+
1729
```html
18-
<auto-complete src="/users/search" aria-owns="users-popup">
30+
<auto-complete src="/users/search" for="users-popup">
1931
<input type="text">
2032
<ul id="users-popup"></ul>
2133
</auto-complete>

examples/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,13 @@
4040
<body>
4141
<form>
4242
<label id="robots-label">Robots</label>
43-
<auto-complete src="/demo" aria-owns="items-popup" aria-labelledby="robots-label">
43+
<auto-complete src="/demo" for="items-popup" aria-labelledby="robots-label">
4444
<input name="robot" type="text" aria-labelledby="robots-label" autofocus>
4545
<ul id="items-popup" aria-labelledby="robots-label"></ul>
4646
</auto-complete>
4747
<button type="submit">Save</button>
4848
</form>
49-
<!-- <script src="../dist/index.umd.js"></script> -->
50-
<script src="https://unpkg.com/@github/auto-complete-element@latest/dist/index.umd.js"></script>
49+
<!-- <script type="module" src="../dist/bundle.js"></script> -->
50+
<script type="module" src="https://unpkg.com/@github/auto-complete-element@latest/dist/bundle.js"></script>
5151
</body>
5252
</html>

0 commit comments

Comments
 (0)