Commit cbf1f4a
Add the missing chat widget + CSS; add 3 gaps found by a second E2E test
Ran a second independent end-to-end build test (fresh Copilot CLI session,
different domain: a "PTO approver" instead of the first test's "expense
approver") to verify the skill's snippets/simplification/bug-fixes actually
help. Result: 12/12 smoke checks, all 7 browser E2E scenarios passed with
screenshots, and verify.sh all green - and per the build's own report, the
bridge snippet worked "completely unmodified except for the AGENT_NAME
constant", azd ai agent init worked exactly as documented, and
verify.sh/smoke.py/browser_e2e.js needed only mechanical domain renames.
Total wall clock was roughly half the first test run's ~1 hour.
That run also surfaced one real, valuable gap: the skill's frontend snippets
only shipped providers.tsx (the <CopilotKit> wrapper + hook registrations)
but never the actual chat WIDGET every consumer needs. The builder had to
discover CopilotChat by reading the installed package's .d.ts files. Added:
- frontend/app/page.tsx - the CopilotChat widget, generalized from this
run's real, working, screenshot-verified code.
- frontend/app/layout.tsx - minimal root layout wiring globals.css + Providers.
- frontend/app/globals.css - plain CSS (no Tailwind dependency) for the
.hitl-card/.tool-card class names, so the approval card/tool cards render
legibly instead of just being present in the DOM unstyled.
Verified these three files by swapping them into the actual test project and
confirming `npm run build` succeeds and the page renders correctly in a
headless browser (screenshot taken, matches expected UI).
Also added 3 troubleshooting.md entries and 1 HITL-section entry for gaps
this run's own REVIEW_NOTES.md flagged: in-memory hosted-agent state is
process-lifetime (restart between verification passes or approvals leak
across runs), a stale process can leave the hosted-agent port bound
(Address already in use on the next `azd ai agent run`), an occasional
transient DeploymentNotFound 404 on the very first request after startup
(retry/restart resolves it), and keeping a renamed gated-tool parameter name
in sync between the Python tool and the frontend's parsed-args cast.
Verified locally with `npx @microsoft/vally-cli lint`: 3/3 checks pass,
21/21 reference files reachable from SKILL.md.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 17ca853 commit cbf1f4a
5 files changed
Lines changed: 125 additions & 0 deletions
File tree
- skills/foundry-hosted-agent-copilotkit/references
- snippets
- frontend/app
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
| |||
Lines changed: 75 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
Lines changed: 25 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
14 | 17 | | |
15 | 18 | | |
16 | 19 | | |
| |||
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| |||
0 commit comments