Skip to content

Commit f1367eb

Browse files
authored
Merge pull request #648 from github/fix/dark-mode-dropdown-text
fix: improve dropdown text visibility in dark mode
2 parents 3c5ac86 + fb4fb59 commit f1367eb

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

website/public/styles/global.css

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,22 +1211,25 @@ a:hover {
12111211
color: var(--color-text-muted);
12121212
}
12131213

1214-
.choices__list--dropdown {
1215-
background-color: var(--color-bg-secondary);
1216-
border-color: var(--color-border);
1214+
.choices__list--dropdown,
1215+
.choices__list[aria-expanded] {
1216+
background-color: var(--color-bg-secondary) !important;
1217+
border-color: var(--color-border) !important;
12171218
border-radius: 0 0 var(--border-radius) var(--border-radius);
12181219
z-index: 100;
12191220
max-height: 300px;
12201221
}
12211222

1222-
.choices__list--dropdown .choices__item {
1223-
color: var(--color-text);
1223+
.choices__list--dropdown .choices__item,
1224+
.choices__list[aria-expanded] .choices__item {
1225+
color: var(--color-text) !important;
12241226
font-size: 14px;
12251227
padding: 10px 14px;
12261228
}
12271229

1228-
.choices__list--dropdown .choices__item--selectable.is-highlighted {
1229-
background-color: var(--color-bg-tertiary);
1230+
.choices__list--dropdown .choices__item--selectable.is-highlighted,
1231+
.choices__list[aria-expanded] .choices__item--selectable.is-highlighted {
1232+
background-color: var(--color-bg-tertiary) !important;
12301233
}
12311234

12321235
.choices__list--multiple .choices__item {
@@ -1260,11 +1263,13 @@ a:hover {
12601263
border-radius: var(--border-radius) var(--border-radius) 0 0;
12611264
}
12621265

1263-
.is-open .choices__list--dropdown {
1266+
.is-open .choices__list--dropdown,
1267+
.is-open .choices__list[aria-expanded] {
12641268
border-color: var(--color-link);
12651269
}
12661270

1267-
.choices__list--dropdown .choices__item--selectable::after {
1271+
.choices__list--dropdown .choices__item--selectable::after,
1272+
.choices__list[aria-expanded] .choices__item--selectable::after {
12681273
display: none;
12691274
}
12701275

0 commit comments

Comments
 (0)