fix: replace bare except with except Exception in analysis.py#1502
fix: replace bare except with except Exception in analysis.py#1502aaronpowell merged 1 commit intogithub:stagedfrom
Conversation
Bare except clauses catch SystemExit and KeyboardInterrupt which prevents clean process termination. Use except Exception per PEP 8.
🔍 Skill Validator Results✅ All checks passed
Summary
Full validator output```text Found 1 skill(s) [datanalysis-credit-risk] 📊 datanalysis-credit-risk: 1,365 BPE tokens [chars/4: 1,546] (detailed ✓), 16 sections, 1 code blocks ✅ All checks passed (1 skill(s)) ``` |
aaronpowell
left a comment
There was a problem hiding this comment.
The test-plugins scripts are unrelated to the PR description, and we already have scripts in the repo related to validating plugins.
|
Hi @aaronpowell, thank you for the feedback! You're right — the test-plugins scripts are unrelated to the bare except fix. I'll remove those commits and keep this PR focused on the except fix only. I can submit the validation framework as a separate PR if there's interest. |
|
We already have validation in |
95e5473 to
722163b
Compare
|
Hi @aaronpowell, I've restructured the PR to keep only the original bare-except fix in \scripts/eval/analysis.py. The validation framework and unrelated commits have been removed. The PR now contains exactly one focused change. Ready for re-review! |
Summary
Replaces bare \�xcept:\ with \�xcept Exception:\ in \skills/publish-to-pages/scripts/convert-pdf.py\ analysis function to avoid catching \SystemExit\ and \KeyboardInterrupt.
Re-targeted to \staged\ branch as requested in #1500.
Signed-off-by: Srikanth Patchava spatchava@meta.com