Skip to content

Fix the nightly report summaries #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JanKrivanek wants to merge 2 commits into from
Closed

Fix the nightly report summaries #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03593cf
Fix the nightly report summaries
JanKrivanek Apr 1, 2026
cc232d3
Fix workflow trigger
JanKrivanek Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-pr-target.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Check PR Target Branch

on:
pull_request:
pull_request_target:
branches: [main]
types: [opened]

Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/skill-quality-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,11 @@ jobs:
const codeowners = parseCodeowners();
// Count findings
// The skill-validator uses emoji markers: ❌ for errors, ⚠ for warnings, ℹ for advisories
const combined = skillsOutput + '\n' + agentsOutput;
const errorCount = (combined.match(/\bError\b/gi) || []).length;
const warningCount = (combined.match(/\bWarning\b/gi) || []).length;
const advisoryCount = (combined.match(/\bAdvisory\b/gi) || []).length;
const errorCount = (combined.match(/❌/g) || []).length;
const warningCount = (combined.match(/⚠/g) || []).length;
const advisoryCount = (combined.match(/ℹ️/g) || []).length;
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new finding counters rely on exact emoji codepoints. In particular, advisories are counted with /ℹ️/g (U+2139 + VS16), but the comment says the marker is ℹ and some outputs render without the variation selector, which would keep advisoryCount at 0. Consider matching both forms (e.g., allow optional VS16) and/or falling back to the previous word-based matching so the summary stays correct across skill-validator output formats.

Suggested change
const advisoryCount = (combined.match(/ℹ️/g) || []).length;
// Match ℹ (U+2139) with optional VS16 (U+FE0F) so both ℹ and ℹ️ are counted
const advisoryCount = (combined.match(/\u2139\uFE0F?/g) || []).length;

Copilot uses AI. Check for mistakes.
// Count total skills & agents checked
let skillDirs = [];
Expand Down
Loading