Fix the nightly report summaries#1251
Merged
aaronpowell merged 3 commits intoApr 1, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the nightly “Skill Quality Report” summary counters by changing how errors/warnings/advisories are counted from the skill-validator output, aligning the workflow with the validator’s current output format.
Changes:
- Switch finding counts from matching
Error/Warning/Advisorywords to counting emoji severity markers in the combined validator output. - Add an inline note documenting the expected emoji markers in the validator output.
Match ℹ with or without the trailing U+FE0F variation selector so advisory counts are reliable regardless of output encoding.
aaronpowell
approved these changes
Apr 1, 2026
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
@aaronpowell - I recall there being an advisory about pull_request_target being a security risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The summary stats in nightly report were all zeroes