Conversation
There was a problem hiding this comment.
main, but PRs should target staged.
The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.
You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1413 --base staged
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR primarily restructures multiple plugin manifests to reference agent/skill directories and adds a broad set of new skills, agents, and reference docs across several plugins—however, the PR title/description claims it adds a foundry-agent-sync skill, which is not present in the provided diffs.
Changes:
- Update many
plugin.jsonfiles to use directory-based./agentsand/or normalized skill paths (no trailing slash). - Add multiple new skills/agents and extensive reference documentation across Go MCP, FlowStudio Power Automate, .NET, database, and Azure pricing plugins.
- Introduce several new “how-to”/template heavy SKILL/agent markdown files.
Reviewed changes
Copilot reviewed 115 out of 306 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/java-development/.github/plugin/plugin.json | Normalizes skill paths (removes trailing slashes). |
| plugins/go-mcp-development/skills/go-mcp-server-generator/SKILL.md | Adds a new Go MCP server generator skill with templates and guidance. |
| plugins/go-mcp-development/agents/go-mcp-expert.md | Adds a Go MCP expert agent definition. |
| plugins/go-mcp-development/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill path. |
| plugins/gem-team/agents/gem-reviewer.md | Adds a security-focused reviewer agent. |
| plugins/gem-team/agents/gem-implementer.md | Adds an implementation/TDD-focused agent. |
| plugins/gem-team/agents/gem-documentation-writer.md | Adds a documentation-focused agent. |
| plugins/gem-team/agents/gem-devops.md | Adds a DevOps-focused agent with approval gates guidance. |
| plugins/gem-team/agents/gem-browser-tester.md | Adds a browser automation/E2E agent definition. |
| plugins/gem-team/.github/plugin/plugin.json | Switches agents to directory reference. |
| plugins/frontend-web-dev/skills/playwright-generate-test/SKILL.md | Adds a Playwright MCP test generation skill. |
| plugins/frontend-web-dev/skills/playwright-explore-website/SKILL.md | Adds a Playwright MCP website exploration skill. |
| plugins/frontend-web-dev/agents/electron-angular-native.md | Adds an Electron/Angular/native integration review-mode agent. |
| plugins/frontend-web-dev/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/connection-references.md | Adds connection reference documentation and examples. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/action-types.md | Adds a Power Automate action-type quick reference. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-mcp/references/MCP-BOOTSTRAP.md | Adds FlowStudio MCP bootstrap connection details. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/debug-workflow.md | Adds end-to-end debugging workflow documentation. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-debug/references/common-errors.md | Adds a catalog of common Power Automate errors/fixes. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/trigger-types.md | Adds trigger templates and examples. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/flow-schema.md | Adds a full flow definition schema reference. |
| plugins/flowstudio-power-automate/skills/flowstudio-power-automate-build/references/build-patterns.md | Adds reusable build pattern templates. |
| plugins/flowstudio-power-automate/.github/plugin/plugin.json | Normalizes skill paths (removes trailing slashes). |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/references/snippets-python3.md | Adds Python 3 snippets and validation guidance. |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/assets/small-territories.json | Adds an asset list of territory codes. |
| plugins/fastah-ip-geo-tools/skills/geofeed-tuner/assets/example/01-user-input-rfc8805-feed.csv | Adds an example CSV input asset. |
| plugins/fastah-ip-geo-tools/.github/plugin/plugin.json | Normalizes skill path (removes trailing slash). |
| plugins/edge-ai-tasks/.github/plugin/plugin.json | Switches agents to directory reference. |
| plugins/doublecheck/skills/doublecheck/assets/verification-report-template.md | Adds a verification report template asset. |
| plugins/doublecheck/agents/doublecheck.md | Adds the Doublecheck verification agent definition. |
| plugins/doublecheck/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill path. |
| plugins/devops-oncall/skills/multi-stage-dockerfile/SKILL.md | Adds a multi-stage Dockerfile skill with best practices. |
| plugins/devops-oncall/agents/azure-principal-architect.md | Adds an Azure principal architect agent definition. |
| plugins/devops-oncall/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-usecase-builder/SKILL.md | Adds a Dataverse Python use-case builder skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-quickstart/SKILL.md | Adds a Dataverse Python quickstart skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-production-code/SKILL.md | Adds a production-code Dataverse Python skill. |
| plugins/dataverse-sdk-for-python/skills/dataverse-python-advanced-patterns/SKILL.md | Adds an advanced patterns Dataverse Python skill. |
| plugins/dataverse-sdk-for-python/.github/plugin/plugin.json | Normalizes skill paths (removes trailing slashes). |
| plugins/database-data-management/skills/postgresql-code-review/SKILL.md | Adds a PostgreSQL-focused code review skill. |
| plugins/database-data-management/agents/postgresql-dba.md | Adds a PostgreSQL DBA agent definition. |
| plugins/database-data-management/agents/ms-sql-dba.md | Adds an MS-SQL DBA agent definition. |
| plugins/database-data-management/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/csharp-mcp-development/skills/csharp-mcp-server-generator/SKILL.md | Adds a C# MCP server generator skill. |
| plugins/csharp-mcp-development/agents/csharp-mcp-expert.md | Adds a C# MCP expert agent definition. |
| plugins/csharp-mcp-development/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill path. |
| plugins/csharp-dotnet-development/skills/dotnet-upgrade/SKILL.md | Adds a .NET upgrade planning skill. |
| plugins/csharp-dotnet-development/skills/dotnet-best-practices/SKILL.md | Adds .NET/C# best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-xunit/SKILL.md | Adds xUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-tunit/SKILL.md | Adds TUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-nunit/SKILL.md | Adds NUnit best practices skill. |
| plugins/csharp-dotnet-development/skills/csharp-async/SKILL.md | Adds C# async best practices skill. |
| plugins/csharp-dotnet-development/skills/aspnet-minimal-api-openapi/SKILL.md | Adds ASP.NET minimal API + OpenAPI skill. |
| plugins/csharp-dotnet-development/agents/expert-dotnet-software-engineer.md | Adds an expert .NET software engineer agent definition. |
| plugins/csharp-dotnet-development/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/copilot-sdk/.github/plugin/plugin.json | Normalizes skill path (removes trailing slash). |
| plugins/context-engineering/skills/what-context-needed/SKILL.md | Adds a “what context is needed” skill. |
| plugins/context-engineering/skills/refactor-plan/SKILL.md | Adds a refactor planning skill. |
| plugins/context-engineering/skills/context-map/SKILL.md | Adds a context mapping skill. |
| plugins/context-engineering/agents/context-architect.md | Adds a context-architect agent definition. |
| plugins/context-engineering/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/clojure-interactive-programming/skills/remember-interactive-programming/SKILL.md | Adds an interactive programming reminder skill. |
| plugins/clojure-interactive-programming/agents/clojure-interactive-programming.md | Adds a Clojure interactive programming agent definition. |
| plugins/clojure-interactive-programming/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill path. |
| plugins/cast-imaging/agents/cast-imaging-structural-quality-advisor.md | Adds a CAST Imaging structural quality advisor agent. |
| plugins/cast-imaging/agents/cast-imaging-software-discovery.md | Adds a CAST Imaging discovery agent. |
| plugins/cast-imaging/agents/cast-imaging-impact-analysis.md | Adds a CAST Imaging impact analysis agent. |
| plugins/cast-imaging/.github/plugin/plugin.json | Switches agents to directory reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/SERVICE-NAMES.md | Adds Azure Retail Prices service name reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/REGIONS.md | Adds Azure Retail Prices region mapping reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/COST-ESTIMATOR.md | Adds cost estimation formulas reference. |
| plugins/azure-cloud-development/skills/azure-pricing/references/COPILOT-STUDIO-RATES.md | Adds Copilot Studio credit rates reference and formulas. |
| plugins/azure-cloud-development/skills/azure-pricing/SKILL.md | Adds/updates Azure pricing skill with API usage and Copilot Studio estimation. |
| plugins/azure-cloud-development/agents/terraform-azure-planning.md | Adds Terraform planning agent instructions. |
| plugins/azure-cloud-development/agents/terraform-azure-implement.md | Adds Terraform implementation agent instructions. |
| plugins/azure-cloud-development/agents/azure-verified-modules-terraform.md | Adds AVM Terraform agent instructions. |
| plugins/azure-cloud-development/agents/azure-verified-modules-bicep.md | Adds AVM Bicep agent instructions. |
| plugins/azure-cloud-development/agents/azure-saas-architect.md | Adds SaaS architect agent instructions. |
| plugins/azure-cloud-development/agents/azure-principal-architect.md | Adds principal architect agent instructions (Azure cloud plugin). |
| plugins/azure-cloud-development/agents/azure-logic-apps-expert.md | Adds Logic Apps expert agent instructions. |
| plugins/azure-cloud-development/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-skills/SKILL.md | Adds a skill to suggest skills from awesome-copilot. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-instructions/SKILL.md | Adds a skill to suggest instruction files from awesome-copilot. |
| plugins/awesome-copilot/skills/suggest-awesome-github-copilot-agents/SKILL.md | Adds a skill to suggest agents from awesome-copilot. |
| plugins/awesome-copilot/agents/meta-agentic-project-scaffold.md | Adds a meta “pull files from awesome-copilot” agent definition. |
| plugins/awesome-copilot/.github/plugin/plugin.json | Switches agents to directory reference; normalizes skill paths. |
| plugins/automate-this/.github/plugin/plugin.json | Normalizes skill path (removes trailing slash). |
| "./agents" | ||
| ], | ||
| "skills": [ | ||
| "./skills/go-mcp-server-generator/" | ||
| "./skills/go-mcp-server-generator" |
There was a problem hiding this comment.
The PR title/description claims this adds a foundry-agent-sync skill, but none of the provided diffs include that skill folder/SKILL.md, and the changes span many unrelated plugins (agents/skills/docs). Either update the PR description/title to reflect the actual scope, or add the missing foundry-agent-sync skill changes (and limit unrelated changes to a separate PR).
| "./agents/gem-devops.md", | ||
| "./agents/gem-reviewer.md", | ||
| "./agents/gem-documentation-writer.md" | ||
| "./agents" |
There was a problem hiding this comment.
Switching agents from explicit file paths to a directory path changes plugin loading semantics. If the plugin loader expects file paths, this will break agent discovery; if it supports directories, it may load unintended files and/or produce non-deterministic ordering depending on filesystem enumeration. Recommend (mandatory) confirming directory paths are supported by the plugin runtime and, if they are, ensuring filtering and stable ordering (or reverting to explicit file lists to keep behavior deterministic).
| "./agents" | |
| "./agents/<agent-1>.agent.md", | |
| "./agents/<agent-2>.agent.md" |
| "connectionName": "shared-sharepointonl-62599557c-1f33-4aec-b4c0-a6e4afcae3be", | ||
| "id": "/providers/Microsoft.PowerApps/apis/shared_sharepointonline", |
There was a problem hiding this comment.
This example includes what looks like a real connection instance identifier (GUID in connectionName). Even if it's not an API key, it can be tenant/user identifying and is inconsistent with other placeholders in the same doc (e.g., xxxxxxxx-...). Replace with a clearly fake placeholder value to avoid accidentally publishing real environment identifiers.
| 5. **Documentation**: Add clear descriptions and examples | ||
| 6. **Testing**: Include at least one test per tool | ||
| 7. **Configuration**: Use environment variables for config | ||
| 8. **Logging**: Use structured logging (log/slog) |
There was a problem hiding this comment.
The instructions require structured logging via log/slog, but the provided main.go template uses the legacy log package. Align the template and the guidance (either update the template to use slog or relax the requirement) so the generated project matches the claimed best practice.
| 8. **Logging**: Use structured logging (log/slog) | |
| 8. **Logging**: Use consistent logging; `log/slog` is preferred, but the standard `log` package is acceptable for minimal templates |
| \`\`\`bash | ||
| go mod download | ||
| go build -o {{PROJECT_NAME}} | ||
| \`\`\` |
There was a problem hiding this comment.
Inside the README template (already in a fenced code block), the backticks are escaped (e.g., \\\\\\bash). That will cause generated READMEs to contain literal backslashes instead of proper Markdown fences. Remove the escaping so the template renders correctly when copied.
| - name: "Project Classification Analysis" | ||
| prompt: "Identify all projects in the solution and classify them by type (`.NET Framework`, `.NET Core`, `.NET Standard`). Analyze each `.csproj` for its current `TargetFramework` and SDK usage." | ||
|
|
||
| - name: "Dependency Compatibility Review" | ||
| prompt: "Review external and internal dependencies for framework compatibility. Determine the upgrade complexity based on dependency graph depth." | ||
|
|
||
| - name: "Legacy Package Detection" | ||
| prompt: "Identify legacy `packages.config` projects needing migration to `PackageReference` format." | ||
|
|
||
| # Upgrade Strategy & Sequencing | ||
| - name: "Project Upgrade Ordering" | ||
| prompt: "Recommend a project upgrade order from least to most dependent components. Suggest how to isolate class library upgrades before API or Azure Function migrations." | ||
|
|
||
| - name: "Incremental Strategy Planning" | ||
| prompt: "Propose an incremental upgrade strategy with rollback checkpoints. Evaluate the use of **Upgrade Assistant** or **manual upgrades** based on project structure." | ||
|
|
||
| - name: "Progress Tracking Setup" | ||
| prompt: "Generate an upgrade checklist for tracking build, test, and deployment readiness across all projects." | ||
|
|
||
| # Framework Targeting & Code Adjustments | ||
| - name: "Target Framework Selection" | ||
| prompt: "Suggest the correct `TargetFramework` for each project (e.g., `net8.0`). Review and update deprecated SDK or build configurations." | ||
|
|
||
| - name: "Code Modernization Analysis" | ||
| prompt: "Identify code patterns needing modernization (e.g., `WebHostBuilder` → `HostBuilder`). Suggest replacements for deprecated .NET APIs and third-party libraries." | ||
|
|
||
| - name: "Async Pattern Conversion" | ||
| prompt: "Recommend conversion of synchronous calls to async where appropriate for improved performance and scalability." | ||
|
|
||
| # NuGet & Dependency Management | ||
| - name: "Package Compatibility Analysis" | ||
| prompt: "Analyze outdated or incompatible NuGet packages and suggest compatible versions. Identify third-party libraries that lack .NET 8 support and provide migration paths." | ||
|
|
||
| - name: "Shared Dependency Strategy" | ||
| prompt: "Recommend strategies for handling shared dependency upgrades across projects. Evaluate usage of legacy packages and suggest alternatives in Microsoft-supported namespaces." | ||
|
|
||
| - name: "Transitive Dependency Review" | ||
| prompt: "Review transitive dependencies and potential version conflicts after upgrade. Suggest resolution strategies for dependency conflicts." | ||
|
|
||
| # CI/CD & Build Pipeline Updates | ||
| - name: "Pipeline Configuration Analysis" | ||
| prompt: "Analyze YAML build definitions for SDK version pinning and recommend updates. Suggest modifications for `UseDotNet@2` and `NuGetToolInstaller` tasks." | ||
|
|
||
| - name: "Build Pipeline Modernization" | ||
| prompt: "Generate updated build pipeline snippets for .NET 8 migration. Recommend validation builds on feature branches before merging to main." | ||
|
|
||
| - name: "CI Automation Enhancement" |
There was a problem hiding this comment.
This skill mixes Markdown headings with YAML-like structured content (indented - name: / prompt: pairs) but does not wrap the structured portion in a code block or convert it into a Markdown table/list format. As-is, it’s hard to read and easy to misinterpret. Consider formatting the structured prompt catalog as a proper Markdown table or wrap it in a fenced block labelled as YAML to make intent unambiguous.
| - name: "Project Classification Analysis" | |
| prompt: "Identify all projects in the solution and classify them by type (`.NET Framework`, `.NET Core`, `.NET Standard`). Analyze each `.csproj` for its current `TargetFramework` and SDK usage." | |
| - name: "Dependency Compatibility Review" | |
| prompt: "Review external and internal dependencies for framework compatibility. Determine the upgrade complexity based on dependency graph depth." | |
| - name: "Legacy Package Detection" | |
| prompt: "Identify legacy `packages.config` projects needing migration to `PackageReference` format." | |
| # Upgrade Strategy & Sequencing | |
| - name: "Project Upgrade Ordering" | |
| prompt: "Recommend a project upgrade order from least to most dependent components. Suggest how to isolate class library upgrades before API or Azure Function migrations." | |
| - name: "Incremental Strategy Planning" | |
| prompt: "Propose an incremental upgrade strategy with rollback checkpoints. Evaluate the use of **Upgrade Assistant** or **manual upgrades** based on project structure." | |
| - name: "Progress Tracking Setup" | |
| prompt: "Generate an upgrade checklist for tracking build, test, and deployment readiness across all projects." | |
| # Framework Targeting & Code Adjustments | |
| - name: "Target Framework Selection" | |
| prompt: "Suggest the correct `TargetFramework` for each project (e.g., `net8.0`). Review and update deprecated SDK or build configurations." | |
| - name: "Code Modernization Analysis" | |
| prompt: "Identify code patterns needing modernization (e.g., `WebHostBuilder` → `HostBuilder`). Suggest replacements for deprecated .NET APIs and third-party libraries." | |
| - name: "Async Pattern Conversion" | |
| prompt: "Recommend conversion of synchronous calls to async where appropriate for improved performance and scalability." | |
| # NuGet & Dependency Management | |
| - name: "Package Compatibility Analysis" | |
| prompt: "Analyze outdated or incompatible NuGet packages and suggest compatible versions. Identify third-party libraries that lack .NET 8 support and provide migration paths." | |
| - name: "Shared Dependency Strategy" | |
| prompt: "Recommend strategies for handling shared dependency upgrades across projects. Evaluate usage of legacy packages and suggest alternatives in Microsoft-supported namespaces." | |
| - name: "Transitive Dependency Review" | |
| prompt: "Review transitive dependencies and potential version conflicts after upgrade. Suggest resolution strategies for dependency conflicts." | |
| # CI/CD & Build Pipeline Updates | |
| - name: "Pipeline Configuration Analysis" | |
| prompt: "Analyze YAML build definitions for SDK version pinning and recommend updates. Suggest modifications for `UseDotNet@2` and `NuGetToolInstaller` tasks." | |
| - name: "Build Pipeline Modernization" | |
| prompt: "Generate updated build pipeline snippets for .NET 8 migration. Recommend validation builds on feature branches before merging to main." | |
| - name: "CI Automation Enhancement" | |
| - **Project Classification Analysis**: Identify all projects in the solution and classify them by type (`.NET Framework`, `.NET Core`, `.NET Standard`). Analyze each `.csproj` for its current `TargetFramework` and SDK usage. | |
| - **Dependency Compatibility Review**: Review external and internal dependencies for framework compatibility. Determine the upgrade complexity based on dependency graph depth. | |
| - **Legacy Package Detection**: Identify legacy `packages.config` projects needing migration to `PackageReference` format. | |
| # Upgrade Strategy & Sequencing | |
| - **Project Upgrade Ordering**: Recommend a project upgrade order from least to most dependent components. Suggest how to isolate class library upgrades before API or Azure Function migrations. | |
| - **Incremental Strategy Planning**: Propose an incremental upgrade strategy with rollback checkpoints. Evaluate the use of **Upgrade Assistant** or **manual upgrades** based on project structure. | |
| - **Progress Tracking Setup**: Generate an upgrade checklist for tracking build, test, and deployment readiness across all projects. | |
| # Framework Targeting & Code Adjustments | |
| - **Target Framework Selection**: Suggest the correct `TargetFramework` for each project (e.g., `net8.0`). Review and update deprecated SDK or build configurations. | |
| - **Code Modernization Analysis**: Identify code patterns needing modernization (e.g., `WebHostBuilder` → `HostBuilder`). Suggest replacements for deprecated .NET APIs and third-party libraries. | |
| - **Async Pattern Conversion**: Recommend conversion of synchronous calls to async where appropriate for improved performance and scalability. | |
| # NuGet & Dependency Management | |
| - **Package Compatibility Analysis**: Analyze outdated or incompatible NuGet packages and suggest compatible versions. Identify third-party libraries that lack .NET 8 support and provide migration paths. | |
| - **Shared Dependency Strategy**: Recommend strategies for handling shared dependency upgrades across projects. Evaluate usage of legacy packages and suggest alternatives in Microsoft-supported namespaces. | |
| - **Transitive Dependency Review**: Review transitive dependencies and potential version conflicts after upgrade. Suggest resolution strategies for dependency conflicts. | |
| # CI/CD & Build Pipeline Updates | |
| - **Pipeline Configuration Analysis**: Analyze YAML build definitions for SDK version pinning and recommend updates. Suggest modifications for `UseDotNet@2` and `NuGetToolInstaller` tasks. | |
| - **Build Pipeline Modernization**: Generate updated build pipeline snippets for .NET 8 migration. Recommend validation builds on feature branches before merging to main. | |
| - **CI Automation Enhancement** |
New Skill:
foundry-agent-syncCreate and synchronize prompt-based AI agents directly within Azure AI Foundry via the Agent Service REST API, from a local JSON manifest.
What it does
Unlike scaffolding skills that only generate local code, this skill registers agents in the Foundry service itself — making them immediately available for invocation, evaluation, and management through the Foundry portal or API.
Key features
useCaseId,description, andbaseInstructionfieldsTrigger phrases
Prerequisites
Checklist
namefield matches folder name (foundry-agent-sync)descriptionexplains WHAT and WHEN with trigger keywords