Fix double-unescaping in decodeEntities (CodeQL alert #32)#1757
Merged
Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code scanning alert #32
Fix double-unescaping in decodeEntities (CodeQL alert #32)
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.stagedbranch for this pull request.Description
Fixes CodeQL alert #32 (
js/double-escaping, CWE-116/CWE-20) inskills/md-to-docx/scripts/md-to-docx.mjs. ThedecodeEntitiesfunction decoded&→&first, enabling double-unescaping:&lt;would resolve to<and then to<. Fix moves&decoding last.Type of Contribution
Additional Notes
Security fix only — no behavior change for correctly encoded input. Affects the
md-to-docxskill's HTML entity decoding path.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.