Adding a new /rerun-intake command for when updates are required#1786
Open
aaronpowell wants to merge 5 commits into
Open
Adding a new /rerun-intake command for when updates are required#1786aaronpowell wants to merge 5 commits into
aaronpowell wants to merge 5 commits into
Conversation
Reruns the intake process if feedback is given that will require the submitter to update something about the submittion.
github-actions
Bot
added
new-submission
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a /rerun-intake issue-comment command to re-run external plugin intake validation (including for closed/rejected submissions), and refactors intake label/comment synchronization into a shared module used by workflows.
Changes:
- Introduces
/rerun-intakeparsing plus shared constants for intake markers/command. - Adds
eng/external-plugin-intake-state.mjsto centralize label syncing + “upsert intake comment” behavior, and updates the intake workflow to use it. - Adds a new workflow to handle
/rerun-intake, and updates docs to reflect the updated resubmission flow.
Show a summary per file
| File | Description |
|---|---|
| eng/external-plugin-intake.mjs | Exports intake markers/command and adds /rerun-intake parser; updates intake failure messaging. |
| eng/external-plugin-intake-state.mjs | New shared helpers to ensure labels, sync managed labels, and upsert the intake comment. |
| .github/workflows/external-plugin-rerun-intake-command.yml | New workflow to authorize and process /rerun-intake comments (author or maintainer). |
| .github/workflows/external-plugin-intake.yml | Adds concurrency and refactors label/comment syncing to shared intake-state module. |
| .github/workflows/external-plugin-approval-command.yml | Updates messaging to reference /rerun-intake as the way to re-queue intake. |
| CONTRIBUTING.md | Documents the new “request another intake pass” step and updated rejection guidance. |
| AGENTS.md | Updates external plugin workflow notes to include /rerun-intake. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 4
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
| runs-on: ubuntu-latest | ||
| if: >- | ||
| !github.event.issue.pull_request && | ||
| startsWith(github.event.comment.body, '/rerun-intake') |
Comment on lines
+105
to
+110
| const { data: comments } = await github.rest.issues.listComments({ | ||
| owner, | ||
| repo, | ||
| issue_number: issueNumber, | ||
| per_page: 100, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reruns the intake process if feedback is given that will require the submitter to update something about the submittion.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.stagedbranch for this pull request.Description
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.