-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding a new /rerun-intake command for when updates are required #1786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronpowell
wants to merge
5
commits into
staged
Choose a base branch
from
re-review-external-plugin-workflow
base: staged
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da14bc7
Adding a new /rerun-intake command for when updates are required
aaronpowell 9e02b68
Merge branch 'staged' into re-review-external-plugin-workflow
aaronpowell 8e1b913
Potential fix for pull request finding
aaronpowell c20b9ca
Potential fix for pull request finding
aaronpowell e414602
Use rerun command constant in parser regex
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124 changes: 124 additions & 0 deletions
124
.github/workflows/external-plugin-rerun-intake-command.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| name: External Plugin Rerun Intake Commands | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| concurrency: | ||
| group: external-plugin-intake-${{ github.event.issue.number }} | ||
| cancel-in-progress: false | ||
|
|
||
| permissions: | ||
| contents: read | ||
| issues: write | ||
|
|
||
| jobs: | ||
| handle-command: | ||
| runs-on: ubuntu-latest | ||
| if: >- | ||
| !github.event.issue.pull_request && | ||
| contains(github.event.comment.body, '/rerun-intake') | ||
|
aaronpowell marked this conversation as resolved.
Outdated
|
||
| steps: | ||
| - name: Checkout staged branch | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1 | ||
| with: | ||
| ref: staged | ||
|
|
||
| - name: Re-run external plugin intake | ||
| uses: actions/github-script@f28e40c7f34bde8b3046d885e986cb6290c5673b # v7.1.0 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| script: | | ||
| const path = require('path'); | ||
| const { pathToFileURL } = require('url'); | ||
|
|
||
| const intake = await import(pathToFileURL(path.join(process.env.GITHUB_WORKSPACE, 'eng', 'external-plugin-intake.mjs')).href); | ||
| const intakeState = await import(pathToFileURL(path.join(process.env.GITHUB_WORKSPACE, 'eng', 'external-plugin-intake-state.mjs')).href); | ||
|
|
||
| const commentAuthor = context.payload.comment.user?.login; | ||
| if (!commentAuthor || context.payload.comment.user?.type === 'Bot' || commentAuthor === 'github-actions[bot]') { | ||
| core.info('Ignoring /rerun-intake from a bot or unknown actor.'); | ||
| return; | ||
| } | ||
|
|
||
| if (!intake.parseRerunIntakeCommand(context.payload.comment.body)) { | ||
| core.info('No supported /rerun-intake command was found.'); | ||
| return; | ||
| } | ||
|
|
||
| const { data: currentIssue } = await github.rest.issues.get({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.issue.number | ||
| }); | ||
|
|
||
| const labelNames = new Set((currentIssue.labels || []).map((label) => label.name)); | ||
| const isExternalPluginIssue = | ||
| labelNames.has('external-plugin') || | ||
| String(currentIssue.body || '').includes(intake.ISSUE_FORM_MARKER); | ||
| if (!isExternalPluginIssue) { | ||
| core.info('Ignoring /rerun-intake because the issue is not an external plugin submission.'); | ||
| return; | ||
| } | ||
|
|
||
| if (labelNames.has('approved') || labelNames.has('re-review-due') || labelNames.has('re-review-follow-up')) { | ||
| core.info('Ignoring /rerun-intake because the issue is already approved or in the six-month re-review flow.'); | ||
| return; | ||
| } | ||
|
|
||
| const issueAuthor = currentIssue.user?.login; | ||
| const isIssueAuthor = Boolean(issueAuthor && commentAuthor === issueAuthor); | ||
|
|
||
| let hasWriteAccess = false; | ||
| if (!isIssueAuthor) { | ||
| const permission = await github.rest.repos.getCollaboratorPermissionLevel({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| username: commentAuthor | ||
| }); | ||
| hasWriteAccess = ['admin', 'write', 'maintain'].includes(permission.data.permission); | ||
| } | ||
|
|
||
| if (!isIssueAuthor && !hasWriteAccess) { | ||
| core.info(`Ignoring /rerun-intake because ${commentAuthor} is neither the issue author nor a maintainer.`); | ||
| return; | ||
| } | ||
|
|
||
| const canRerunFromCurrentState = currentIssue.state === 'open' || labelNames.has('rejected'); | ||
| if (!canRerunFromCurrentState) { | ||
| core.info('Ignoring /rerun-intake because the issue is closed outside the intake/rejection flow.'); | ||
| return; | ||
| } | ||
|
|
||
| const evaluation = await intake.evaluateExternalPluginIssue({ | ||
| issue: currentIssue, | ||
| token: process.env.GITHUB_TOKEN | ||
| }); | ||
|
|
||
| await intakeState.applyExternalPluginIntakeEvaluation({ | ||
| github, | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issueNumber: context.issue.number, | ||
| evaluation | ||
| }); | ||
|
|
||
| if (evaluation.valid && currentIssue.state === 'closed' && labelNames.has('rejected')) { | ||
| await github.rest.issues.update({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.issue.number, | ||
| state: 'open' | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| if (!evaluation.valid && currentIssue.state === 'open') { | ||
| await github.rest.issues.update({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.issue.number, | ||
| state: 'closed' | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.