Enhance the skill to include sampling of data, to detect better joins.#590
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Snowflake semantic views skill by adding guidance for data sampling to better detect joins and relationships between tables. The changes include renaming the skill from snowflake-semanticview to snowflake-semantic-views and adding instructions for sampling data, validating with queries, and improving the workflow steps.
Changes:
- Added data sampling step (step 5) with SELECT DISTINCT queries limited to 1000 rows for discovering relationships and data types
- Added example query syntax (step 10) for validating the final semantic view works correctly
- Renamed the skill from
snowflake-semanticviewtosnowflake-semantic-viewsin both the SKILL.md name field and README table - Renumbered subsequent workflow steps to accommodate the new additions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| skills/snowflake-semanticview/SKILL.md | Updated skill name, added data sampling step, added validation query example, and renumbered workflow steps |
| docs/README.skills.md | Updated skill name reference in the skills table to match new name |
…wflake-semanticview'
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MiguelElGallo
marked this pull request as draft
January 18, 2026 12:12
MiguelElGallo
marked this pull request as ready for review
January 18, 2026 12:12
aaronpowell
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
An update to an existing skill.
Type of Contribution
Additional Notes
Added some paragraphs to the .md file, for better guidance to the agent.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.