Conversation
…rove folder structure, and clarify PowerProvider implementation
There was a problem hiding this comment.
Pull request overview
Updates the Power Apps Code Apps instruction guide to reflect newer SDK guidance and reorganized project structure conventions for generated artifacts.
Changes:
- Updates the referenced Power Platform SDK version and adjusts PowerProvider guidance (removing explicit SDK initialization in the example).
- Refines recommended project structure by moving generated
services/andmodels/undersrc/generated/. - Updates limitations/troubleshooting text and performs whitespace/formatting cleanup in examples.
| - PowerProvider implementation pattern (no SDK initialization required in v1.0): | ||
| ```typescript | ||
| import { initialize } from "@microsoft/power-apps/app"; | ||
| import { useEffect, type ReactNode } from "react"; | ||
| import type { ReactNode } from "react"; | ||
|
|
||
| export default function PowerProvider({ children }: { children: ReactNode }) { | ||
| useEffect(() => { | ||
| const initApp = async () => { | ||
| try { | ||
| await initialize(); | ||
| console.log('Power Platform SDK initialized successfully'); | ||
| } catch (error) { | ||
| console.error('Failed to initialize Power Platform SDK:', error); | ||
| } | ||
| }; | ||
| initApp(); | ||
| }, []); | ||
| return <>{children}</>; | ||
| } |
There was a problem hiding this comment.
The PowerProvider example is described as a “context wrapper”, but the sample implementation is only a fragment passthrough and provides no context/value. Either update the example to demonstrate the intended provider/context responsibilities (or where SDK setup occurs), or adjust the wording so readers don’t assume this component sets up Power Platform context.
| - No Dataverse solutions support | ||
| - No native Azure Application Insights integration | ||
| - Dataverse solutions supported, but solution packager and source code integration are limited | ||
| - Application Insights supported through SDK logger configuration (no built-in native integration) |
There was a problem hiding this comment.
These updated “Known Limitations” entries (Dataverse solutions + Application Insights support) now diverge from the limitations listed in agents/power-platform-expert.agent.md (which still says “no native Application Insights”). To avoid confusing users who install the whole collection, please reconcile the limitations wording across the related agent/prompt/instructions or add a pointer to the authoritative source/version these statements apply to.
| - Application Insights supported through SDK logger configuration (no built-in native integration) | |
| - Application Insights has no native built-in integration; only limited, non-native wiring via SDK logger configuration is possible (see `agents/power-platform-expert.agent.md` for canonical limitations) |
| - **Power Apps Code Apps**: Code-first web app development with Power Platform integration | ||
| - **TypeScript + React**: Recommended frontend stack with Vite bundler | ||
| - **Power Platform SDK**: @microsoft/power-apps (current version ^0.3.1) for connector integration | ||
| - **Power Platform SDK**: @microsoft/power-apps (current version ^1.0.3) for connector integration |
There was a problem hiding this comment.
This instruction now states the Power Apps SDK “current version” is @microsoft/power-apps ^1.0.3, but other Power Apps Code Apps assets in this repo still reference ^0.3.1 (e.g., prompts/power-apps-code-app-scaffold.prompt.md and agents/power-platform-expert.agent.md). This creates conflicting guidance within the same collection—please align the version (and any associated guidance) across the related prompt/agent or avoid calling a specific version “current” here.
| - **Power Platform SDK**: @microsoft/power-apps (current version ^1.0.3) for connector integration | |
| - **Power Platform SDK**: @microsoft/power-apps for connector integration |
aaronpowell
closed this pull request by merging all changes
into
github:main
in
77a979d
|
Just making sure that this wasn't closed by accident - are the changes covered in #701 too? |
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.