fix/license text overflow#1336
Closed
MagicDevM wants to merge 3 commits into
Closed
Conversation
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
Author
|
Uh do you want me to do something? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix horizontal overflow of the license text block on smaller (and sometimes larger) screens by adjusting styling for the license text <pre> element.
Changes:
- Adds
overflow-wrap: break-word;to.license-body preinassets/css/application.scssto encourage long tokens to wrap instead of overflowing.
Show a summary per file
| File | Description |
|---|---|
| assets/css/application.scss | Adds an overflow-wrap rule to the license text <pre> styling to address overflow. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| -o-border-radius: 3px; | ||
| border-radius: 3px; | ||
| padding: 20px; | ||
| overflow-wrap: break-word; |
Contributor
|
@MagicDevM did you test this PR? Based on a quick check using browser tools, the Copilot review above is correct. |
Author
|
Ill reopen this with cleaner git history later for now closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite self explanatory it fixes the overflow of license text caused on small-medium screens(sometimes large too).