Changes from CR

Author: oscarsj

lib/analyze-action.js

@@ -65,16 +65,20 @@ export function resolveToolsInput(
   const toolsPropertyValue: string | undefined =
     repositoryProperties[toolsPropertyName];
   const effectiveToolsInput = toolsWorkflowInput ?? toolsPropertyValue;
-  
+
   // Log the source of the tools input for transparency
   if (effectiveToolsInput) {
     if (toolsWorkflowInput) {
-      logger.info(`Setting tools: ${effectiveToolsInput} based on workflow input.`);
+      logger.info(
+        `Setting tools: ${effectiveToolsInput} based on workflow input.`,
+      );
     } else {
-      logger.info(`Setting tools: ${effectiveToolsInput} based on the '${toolsPropertyName}' repository property.`);
+      logger.info(
+        `Setting tools: ${effectiveToolsInput} based on the '${toolsPropertyName}' repository property.`,
+      );
     }
   }
-  
+
   return effectiveToolsInput;
 }
 

lib/init-action-post.js

@@ -113,6 +113,7 @@ test.serial(
         false,
         features,
         getRunnerLogger(true),
+        false,
       );
 
       t.is(source.sourceType, "download");
@@ -136,6 +137,7 @@ test.serial(
         false,
         features,
         getRunnerLogger(true),
+        false,
       );
 
       t.is(source.toolsVersion, LINKED_CLI_VERSION.cliVersion);
@@ -161,6 +163,7 @@ test.serial(
         false,
         features,
         logger,
+        false,
       );
 
       // First, ensure that the CLI version is the linked version, so that backwards
@@ -323,6 +326,7 @@ test.serial(
         false,
         features,
         logger,
+        false,
       );
 
       // Check that the `CodeQLToolsSource` object matches our expectations.
@@ -384,6 +388,7 @@ test.serial(
         false,
         features,
         logger,
+        false,
       );
 
       // Check that the `CodeQLToolsSource` object matches our expectations.
@@ -438,6 +443,7 @@ test.serial(
         false,
         features,
         logger,
+        false,
       );
 
       // Check that the toolcache functions were called with the expected arguments
@@ -505,6 +511,7 @@ const toolcacheInputFallbackMacro = test.macro({
         false,
         features,
         logger,
+        false,
       );
 
       // Check that the toolcache functions were called with the expected arguments

lib/init-action.js

@@ -287,7 +287,7 @@ export async function getCodeQLSource(
   tarSupportsZstd: boolean,
   features: FeatureEnablement,
   logger: Logger,
-  toolsInputFromRepositoryProperty: boolean = false,
+  toolsInputFromRepositoryProperty: boolean,
 ): Promise<CodeQLToolsSource> {
   // If there is an explicit `tools` input, it's not one of the reserved values, and it doesn't appear
   // to point to a URL, then we assume it is a local path and use the CLI from there.
@@ -361,9 +361,7 @@ export async function getCodeQLSource(
         ),
       );
     } else {
-      logger.info(
-        `Using the latest CodeQL CLI nightly, as requested.`,
-      );
+      logger.info(`Using the latest CodeQL CLI nightly, as requested.`);
     }
     toolsInput = await getNightlyToolsUrl(logger);
   }
@@ -409,8 +407,7 @@ export async function getCodeQLSource(
     );
     const allowToolcacheValue =
       toolsInputFromRepositoryProperty || // Repository properties bypass all restrictions
-      (allowToolcacheValueFF &&
-        (isDynamicWorkflow() || util.isInTestMode()));
+      (allowToolcacheValueFF && (isDynamicWorkflow() || util.isInTestMode()));
     if (allowToolcacheValue) {
       // If `toolsInput === "toolcache"`, try to find the latest version of the CLI that's available in the toolcache
       // and use that. We perform this check here since we can set `cliVersion` directly and don't want to default to