Skip to content

Fix rebuild Action #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 4 commits into from
Mar 11, 2026
Merged

Fix rebuild Action #3568

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4472004
CI: Set up Node.js 24 in rebuild workflow
henrymercer Mar 11, 2026
6fb1c2a
Fix merge in progress detection
henrymercer Mar 11, 2026
5f3f250
Fix finishing up in progress merge
henrymercer Mar 11, 2026
567ca73
Address review comments
henrymercer Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/rebuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ jobs:
fetch-depth: 0
ref: ${{ env.HEAD_REF }}

- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: 24
cache: 'npm'
Comment thread
henrymercer marked this conversation as resolved.

- name: Remove label
if: github.event_name == 'pull_request'
env:
Expand All @@ -49,8 +55,12 @@ jobs:
git fetch origin "$BASE_BRANCH"

# Allow merge conflicts in `lib`, since rebuilding should resolve them.
git merge "origin/$BASE_BRANCH" || echo "Merge conflicts detected, continuing."
MERGE_RESULT=$?
if git merge "origin/$BASE_BRANCH"; then
MERGE_RESULT=0
else
MERGE_RESULT=$?
echo "Merge conflicts detected, continuing."
Comment thread
henrymercer marked this conversation as resolved.
Outdated
fi

if [ "$MERGE_RESULT" -ne 0 ]; then
echo "merge-in-progress=true" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -104,7 +114,7 @@ jobs:
# Otherwise, just commit the changes.
if git rev-parse --verify MERGE_HEAD >/dev/null 2>&1; then
echo "In progress merge detected, finishing it up."
git merge --continue --no-edit
git commit --no-edit
else
echo "No in-progress merge detected, committing changes."
git commit -m "Rebuild"
Expand Down
Loading