Revert "Address copilot review"

This reverts commit 9d539a3.

The commit itself is good, but it should not be done in this branch.

Author: MichaelRFairhurst

.github/workflows/codeql_unit_tests.yml

@@ -15,6 +15,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
 

.github/workflows/extra-rule-validation.yml

@@ -15,6 +15,7 @@ on:
       - main
       - "rc/**"
       - next
+      - michaelrfairhurst/package-undefined-behavior
 
 
 jobs:

.github/workflows/tooling-unit-tests.yml

@@ -15,6 +15,7 @@ on:
       - main
       - "rc/**"
       - next
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   prepare-supported-codeql-env-matrix:

.github/workflows/validate-package-files.yml

@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   validate-package-files:

.github/workflows/validate-query-help.yml

@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 jobs:
   validate-query-help-files:

.github/workflows/validate-query-test-case-formatting.yml

@@ -9,6 +9,7 @@ on:
       - main
       - next
       - "rc/**"
+      - michaelrfairhurst/package-undefined-behavior
 
 env:
   XARGS_MAX_PROCS: 4

cpp/common/src/codingstandards/cpp/rules/possibledataracebetweenthreadsshared/PossibleDataRaceBetweenThreadsShared.qll

@@ -37,7 +37,7 @@ module PossibleDataRaceBetweenThreadsShared<PossibleDataRaceBetweenThreadsShared
     TStdFunctionCall(FunctionCall call) {
       call.getTarget()
           .hasName([
-              "setlocale", "tmpnam", "rand", "srand", "getenv", "getenv_s", "strtok", "strerror",
+              "setlocale", "tmpnam", "rand", "srand", "getenv", "getenv_s", "strok", "strerror",
               "asctime", "ctime", "gmtime", "localtime", "mbrtoc16", "c16rtomb", "mbrtoc32",
               "c32rtomb", "mbrlen", "mbrtowc", "wcrtomb", "mbsrtowcs", "wcsrtombs"
             ])

cpp/common/test/rules/possibledataracebetweenthreadsshared/PossibleDataRaceBetweenThreadsShared.expected

@@ -8,8 +8,6 @@
 | test.cpp:93:3:93:6 | call to rand | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:93:3:93:6 | call to rand | rand | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:93:3:93:6 | call to rand | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
 | test.cpp:94:3:94:11 | call to rand | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:94:3:94:11 | call to rand | rand | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:94:3:94:11 | call to rand | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
 | test.cpp:96:3:96:8 | call to getenv | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:96:3:96:8 | call to getenv | getenv | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:96:3:96:8 | call to getenv | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
-| test.cpp:99:3:99:8 | call to strtok | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:99:3:99:8 | call to strtok | strtok | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:99:3:99:8 | call to strtok | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
-| test.cpp:100:3:100:13 | call to strtok | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:100:3:100:13 | call to strtok | strtok | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:100:3:100:13 | call to strtok | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
 | test.cpp:101:3:101:10 | call to strerror | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:101:3:101:10 | call to strerror | strerror | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:101:3:101:10 | call to strerror | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
 | test.cpp:102:3:102:15 | call to strerror | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:102:3:102:15 | call to strerror | strerror | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:102:3:102:15 | call to strerror | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |
 | test.cpp:103:3:103:9 | call to asctime | Threaded call to non-reentrant function $@ not synchronized from thread function $@ spawned from a loop. | test.cpp:103:3:103:9 | call to asctime | asctime | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs | test.cpp:103:3:103:9 | call to asctime | concurrent call to non-reentrant function | test.cpp:86:6:86:43 | many_thread13_calls_nonreentrant_funcs | many_thread13_calls_nonreentrant_funcs |

cpp/common/test/rules/possibledataracebetweenthreadsshared/test.cpp

@@ -89,15 +89,15 @@ void many_thread13_calls_nonreentrant_funcs(void *p) {
   // Not all are defined in std:: in our stubs.
   std::setlocale(LC_ALL, "C"); // NON-COMPLIANT
   setlocale(LC_ALL, "C");      // NON-COMPLIANT
-  std::tmpnam(nullptr);        // NON-COMPLIANT
+  std::tmpnam("");             // NON-COMPLIANT
   rand();                      // NON-COMPLIANT
   std::rand();                 // NON-COMPLIANT
   // srand(0);                       // NON-COMPLIANT
   getenv("PATH"); // NON-COMPLIANT
   // std::getenv("PATH");                 // NON-COMPLIANT
   ////getenv_s(NULL, NULL, 0, NULL);  // NON-COMPLIANT
-  strtok("a", "b");      // NON-COMPLIANT
-  std::strtok("a", "b"); // NON-COMPLIANT
+  strtok("a", "b");      // NON-COMPLIANT[False negative]
+  std::strtok("a", "b"); // NON-COMPLIANT[False negative]
   strerror(0);           // NON-COMPLIANT
   std::strerror(0);      // NON-COMPLIANT
   asctime(NULL);         // NON-COMPLIANT