copilot feedback

Author: MichaelRFairhurst

cpp/common/src/codingstandards/cpp/types/Predicate.qll

@@ -18,8 +18,8 @@ private import semmle.code.cpp.dataflow.new.DataFlow
  *
  * To be more widely useful, we match more flexibly on the name, as `_Compare` is also common, etc.
  *
- * To get a particular `Type` that is _used_ as a predicate type, see `getASubstitutedType()`,
- * rather than the type parameter itself, see `getASubstitutedType()`.
+ * To get a particular `Type` that is _used_ as a predicate type, rather than the type parameter
+ * itself, see `getASubstitutedType()`.
  */
 class PredicateType extends TypeTemplateParameter {
   PredicateType() {

cpp/common/src/codingstandards/cpp/types/Templates.qll

@@ -10,7 +10,7 @@ private newtype TSubstitution =
  * `TemplateClass`, `TemplateFunction`, or `TemplateVariable`, which complicates their usage.
  *
  * A `Substitution` in particular refers to an instantiation of that template of some kind, and
- * allows analysis of which parameters were substituted with which types in that instatiation.
+ * allows analysis of which parameters were substituted with which types in that instantiation.
  */
 class Substitution extends TSubstitution {
   ClassTemplateInstantiation asClassSubstitution() { this = TClassSubstitution(result) }
@@ -61,7 +61,7 @@ class Substitution extends TSubstitution {
   }
 
   /**
-   * Get a `Locatable` that represents a where this substitution was declared in the source code.
+   * Get a `Locatable` that represents where this substitution was declared in the source code.
    *
    * The result may be a `TypeMention`, `Call`, etc. depending on the kind of template and how it is
    * being used, but it handles the various template cases for you.

cpp/misra/src/rules/RULE-28-3-1/NonConstPredicateFunctionObject.ql

@@ -30,4 +30,4 @@ where
   not callOperator instanceof ConstMemberFunction
 select usageSite, "Predicate usage of $@ has $@", callOperator.getDeclaringType(),
   "callable object " + callOperator.getDeclaringType().getName(), callOperator,
-  "non const operator()."
+  "non-const operator()."

cpp/misra/test/rules/RULE-28-3-1/NonConstPredicateFunctionObject.expected

@@ -1,2 +1,2 @@
-| test.cpp:15:8:15:10 | type mention | Predicate usage of $@ has $@ | test.cpp:10:8:10:9 | F1 | callable object F1 | test.cpp:11:8:11:17 | operator() | non const operator(). |
-| test.cpp:20:3:20:11 | call to sort | Predicate usage of $@ has $@ | test.cpp:10:8:10:9 | F1 | callable object F1 | test.cpp:11:8:11:17 | operator() | non const operator(). |
+| test.cpp:15:8:15:10 | type mention | Predicate usage of $@ has $@ | test.cpp:10:8:10:9 | F1 | callable object F1 | test.cpp:11:8:11:17 | operator() | non-const operator(). |
+| test.cpp:20:3:20:11 | call to sort | Predicate usage of $@ has $@ | test.cpp:10:8:10:9 | F1 | callable object F1 | test.cpp:11:8:11:17 | operator() | non-const operator(). |