Add pragma to equal types to improve perf

Author: knewbury01

cpp/common/src/codingstandards/cpp/rules/incompatibleobjectdeclaration/IncompatibleObjectDeclaration.qll

@@ -19,10 +19,14 @@ class VariableDeclarationEntryExternal extends VariableDeclarationEntry {
   VariableDeclarationEntryExternal() { this.getDeclaration() instanceof ExternalIdentifiers }
 }
 
+predicate relevantPair(VariableDeclarationEntryExternal varA, VariableDeclarationEntryExternal varB) {
+  not varA = varB and
+  varA.getVariable().getName() = varB.getVariable().getName()
+}
+
 predicate relevantTypes(Type a, Type b) {
   exists(VariableDeclarationEntryExternal varA, VariableDeclarationEntryExternal varB |
-    not varA = varB and
-    varA.getVariable().getName() = varB.getVariable().getName() and
+    relevantPair(varA, varB) and
     a = varA.getType() and
     b = varB.getType()
   )
@@ -35,11 +39,10 @@ module IncompatibleObjectDeclaration<IncompatibleObjectDeclarationConfigSig Conf
   ) {
     not isExcluded(decl1, Config::getQuery()) and
     not isExcluded(decl2, Config::getQuery()) and
+    relevantPair(decl1, decl2) and
     not TypeEquivalence<TypesCompatibleConfig, relevantTypes/2>::equalTypes(decl1.getType(),
       decl2.getType()) and
-    not decl1 = decl2 and
     decl1.getLocation().getStartLine() >= decl2.getLocation().getStartLine() and
-    decl1.getVariable().getName() = decl2.getVariable().getName() and
     secondMessage = decl2.getName() and
     message = "The object is not compatible with a re-declaration $@."
   }

cpp/common/src/codingstandards/cpp/types/Compatible.qll

@@ -379,6 +379,7 @@ module TypeEquivalence<TypeEquivalenceSig Config, interestedInEquality/2 interes
    * `interestedInNestedTypes` holds for the types, and holds if `t1` and `t2` are identical,
    * regardless of how `TypeEquivalenceSig` is defined.
    */
+  pragma[nomagic]
   predicate equalTypes(Type t1, Type t2) {
     interestedInNestedTypes(pragma[only_bind_into](t1), pragma[only_bind_into](t2)) and
     (