Type inference: Disable universal conditions by default

Author: hvitved

rust/ql/lib/codeql/rust/internal/TypeInference.qll

@@ -2188,8 +2188,6 @@ private module MethodResolution {
         exists(mc) and
         constraint.(TraitType).getTrait() instanceof DerefTrait
       }
-
-      predicate useUniversalConditions() { none() }
     }
 
     private module MethodCallSatisfiesDerefConstraint =
@@ -3561,8 +3559,6 @@ private module AwaitSatisfiesConstraintInput implements SatisfiesConstraintInput
     exists(term) and
     constraint.(TraitType).getTrait() instanceof FutureTrait
   }
-
-  predicate useUniversalConditions() { none() }
 }
 
 pragma[nomagic]
@@ -3759,8 +3755,6 @@ private module ForIterableSatisfiesConstraintInput implements
       t instanceof IntoIteratorTrait
     )
   }
-
-  predicate useUniversalConditions() { none() }
 }
 
 pragma[nomagic]
@@ -3812,8 +3806,6 @@ private module InvokedClosureSatisfiesConstraintInput implements
     exists(term) and
     constraint.(TraitType).getTrait() instanceof FnOnceTrait
   }
-
-  predicate useUniversalConditions() { none() }
 }
 
 /** Gets the type of `ce` when viewed as an implementation of `FnOnce`. */

rust/ql/lib/codeql/rust/internal/typeinference/BlanketImplementation.qll

@@ -117,8 +117,6 @@ module SatisfiesBlanketConstraint<
     predicate relevantConstraint(ArgumentTypeAndBlanketOffset ato, Type constraint) {
       relevantConstraint(ato, _, constraint.(TraitType).getTrait())
     }
-
-    predicate useUniversalConditions() { none() }
   }
 
   private module SatisfiesBlanketConstraint =

shared/typeinference/codeql/typeinference/internal/TypeInference.qll

@@ -849,7 +849,7 @@ module Make1<LocationSig Location, InputSig1<Location> Input1> {
        * checked. Hence using these represent a trade-off between too many
        * constraints and too few constraints being satisfied.
        */
-      default predicate useUniversalConditions() { any() }
+      default predicate useUniversalConditions() { none() }
     }
 
     module SatisfiesConstraint<