C++: Fix pointer indirection. Currently, this does not have any effect because of a conflation bug in taint-tracking.

MathiasVP · MathiasVP · commit 16a7e39e951e · 2026-03-31T15:26:15.000+01:00
diff --git a/cpp/ql/lib/semmle/code/cpp/models/implementations/Http.qll b/cpp/ql/lib/semmle/code/cpp/models/implementations/Http.qll
@@ -54,7 +54,7 @@ private class HttpRequestHeadersInheritingContent extends TaintInheritingContent
       this.getIndirectionIndex() = 1
       or
       this.getAField().hasName("pUnknownHeaders") and
-      this.getIndirectionIndex() = 1
+      this.getIndirectionIndex() = 2
     )
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ private class HttpRequestHeadersInheritingContent extends TaintInheritingContent`
`54`	`54`	`this.getIndirectionIndex() = 1`
`55`	`55`	`or`
`56`	`56`	`this.getAField().hasName("pUnknownHeaders") and`
`57`		`- this.getIndirectionIndex() = 1`
	`57`	`+ this.getIndirectionIndex() = 2`
`58`	`58`	`)`
`59`	`59`	`}`
`60`	`60`	`}`