C++: Tests showing problems with casts of typedefs

Author: jbj

cpp/ql/test/query-tests/Likely Bugs/Arithmetic/PointlessComparison/PointlessComparison.c

@@ -265,3 +265,23 @@ int negative_zero(double dbl) {
   }
   return 0;
 }
+
+typedef unsigned char u8;
+
+int widening_cast1(u8 c) {
+  if (c == 0) {
+    if ((int)c > 0) { // BAD [NOT DETECTED]
+      return 1;
+    }
+  }
+  return 0;
+}
+
+int widening_cast2(u8 c) {
+  if (c <= 10)
+    return -1;
+  else if ((c >= 11) /* BAD [NOT DETECTED] */ && (c <= 47))
+    return 0;
+  else
+    return 1;
+}