python/ruby/js: barriers are sources, barrier guards are sinks

yoff · yoff · commit 2056323cbd6b · 2026-01-19T10:02:54.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModels.qll b/javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModels.qll
@@ -872,7 +872,7 @@ module ModelOutput {
    * Holds if `node` is specified as a barrier with the given kind in an external model.
    */
   predicate barrierNode(DataFlow::Node node, string kind) {
-    node = getABarrierNode(kind).asSink()
+    node = getABarrierNode(kind).asSource()
     or
     node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)
   }
diff --git a/python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll b/python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll
@@ -872,7 +872,7 @@ module ModelOutput {
    * Holds if `node` is specified as a barrier with the given kind in an external model.
    */
   predicate barrierNode(DataFlow::Node node, string kind) {
-    node = getABarrierNode(kind).asSink()
+    node = getABarrierNode(kind).asSource()
     or
     node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)
   }
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/data/internal/ApiGraphModels.qll b/ruby/ql/lib/codeql/ruby/frameworks/data/internal/ApiGraphModels.qll
@@ -872,7 +872,7 @@ module ModelOutput {
    * Holds if `node` is specified as a barrier with the given kind in an external model.
    */
   predicate barrierNode(DataFlow::Node node, string kind) {
-    node = getABarrierNode(kind).asSink()
+    node = getABarrierNode(kind).asSource()
     or
     node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)
   }

Original file line number	Diff line number	Diff line change
`@@ -872,7 +872,7 @@ module ModelOutput {`
`872`	`872`	* Holds if `node` is specified as a barrier with the given kind in an external model.
`873`	`873`	`*/`
`874`	`874`	`predicate barrierNode(DataFlow::Node node, string kind) {`
`875`		`- node = getABarrierNode(kind).asSink()`
	`875`	`+ node = getABarrierNode(kind).asSource()`
`876`	`876`	`or`
`877`	`877`	`node = DataFlow::ExternalBarrierGuard::getAnExternalBarrierNode(kind)`
`878`	`878`	`}`