QL: move implementation of implicit-this to Query.qll file

Author: erik-krogh

ql/src/codeql_ql/style/ImplicitThisQuery.qll

@@ -0,0 +1,20 @@
+import ql
+
+MemberCall explicitThisCallInFile(File f) {
+  result.getLocation().getFile() = f and
+  result.getBase() instanceof ThisAccess and
+  // Exclude `this.(Type).whatever(...)`, as some files have that as their only instance of `this`.
+  not result = any(InlineCast c).getBase()
+}
+
+PredicateCall implicitThisCallInFile(File f) {
+  result.getLocation().getFile() = f and
+  exists(result.getTarget().getDeclaringType().getASuperType()) and
+  // Exclude `SomeModule::whatever(...)`
+  not exists(result.getQualifier())
+}
+
+PredicateCall confusingImplicitThisCall(File f) {
+  result = implicitThisCallInFile(f) and
+  exists(explicitThisCallInFile(f))
+}

ql/src/queries/style/ImplicitThis.ql

@@ -9,25 +9,7 @@
  */
 
 import ql
-
-MemberCall explicitThisCallInFile(File f) {
-  result.getLocation().getFile() = f and
-  result.getBase() instanceof ThisAccess and
-  // Exclude `this.(Type).whatever(...)`, as some files have that as their only instance of `this`.
-  not result = any(InlineCast c).getBase()
-}
-
-PredicateCall implicitThisCallInFile(File f) {
-  result.getLocation().getFile() = f and
-  exists(result.getTarget().getDeclaringType().getASuperType()) and
-  // Exclude `SomeModule::whatever(...)`
-  not exists(result.getQualifier())
-}
-
-PredicateCall confusingImplicitThisCall(File f) {
-  result = implicitThisCallInFile(f) and
-  exists(explicitThisCallInFile(f))
-}
+import codeql_ql.style.ImplicitThisQuery
 
 from PredicateCall c
 where c = confusingImplicitThisCall(_)