Skip to content

Commit 39e0382

Browse files
committed
Improve QLDoc for isTypeExprTopDown
1 parent 22e012c commit 39e0382

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

go/ql/lib/semmle/go/Expr.qll

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2131,11 +2131,12 @@ private predicate isTypeExprBottomUp(Expr e) {
21312131
* Holds if `e` must be a type expression because it either occurs in a syntactic
21322132
* position where a type is expected, or it is part of a larger type expression.
21332133
*
2134-
* This predicate is only needed on snapshots for which type information is
2135-
* incomplete. It is an underapproximation; in cases where it is syntactically ambiguous
2136-
* whether an expression refers to a type or a value, we conservatively assume that
2137-
* it may be the latter and so this predicate does not consider the expression to be
2138-
* a type expression.
2134+
* This predicate is only needed on databases for which type information is
2135+
* incomplete - for example, when some dependencies could not be reached during
2136+
* extraction. It is an underapproximation; in cases where it is syntactically
2137+
* ambiguous whether an expression refers to a type or a value, we conservatively
2138+
* assume that it may be the latter and so this predicate does not consider the
2139+
* expression to be a type expression.
21392140
*/
21402141
pragma[nomagic]
21412142
private predicate isTypeExprTopDown(Expr e) {

0 commit comments

Comments
 (0)