Rust: Remove type at self position for tuple-like constructors

Author: paldepind

rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

@@ -3103,9 +3103,6 @@ abstract private class TupleLikeConstructor extends Addressable {
     or
     pos.isReturn() and
     result = this.getReturnType(path)
-    or
-    pos.isSelf() and
-    result = this.getReturnType(path)
   }
 
   Type getParameterType(FunctionPosition pos, TypePath path) {
@@ -3840,15 +3837,15 @@ private module TupleStructPatMatchingInput implements MatchingInputSig {
       result = this.getField(apos.asPosition())
       or
       result = this and
-      apos.isSelf()
+      apos.isReturn()
     }
 
     Type getInferredType(AccessPosition apos, TypePath path) {
       result = inferType(this.getNodeAt(apos), path)
       or
       // The struct/enum type is supplied explicitly as a type qualifier, e.g.
       // `let Option::<Foo>::Some(x) = ...`.
-      apos.isSelf() and
+      apos.isReturn() and
       result = this.getPath().(TypeMention).getTypeAt(path)
     }