wip5

Author: hvitved

rust/ql/lib/codeql/rust/elements/internal/generated/Impl.qll

@@ -1802,13 +1802,6 @@ private module AssocFunctionResolution {
       result != TUnknownType()
     }
 
-    private Type testgetComplexStrippedSelfType(
-      FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow, TypePath strippedTypePath
-    ) {
-      result = this.getComplexStrippedSelfType(selfPos, derefChain, borrow, strippedTypePath) and
-      this = Debug::getRelevantLocatable()
-    }
-
     pragma[nomagic]
     Type getComplexStrippedSelfType(
       FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow, TypePath strippedTypePath
@@ -1827,8 +1820,7 @@ private module AssocFunctionResolution {
      */
     pragma[nomagic]
     predicate hasNoCompatibleTargetNoBorrow(FunctionPosition selfPos, DerefChain derefChain) {
-      Foo<hasNoCompatibleTargetNoBorrowToIndex/4>::hasNoCompatibleTargetCheck(this, selfPos,
-        derefChain, _)
+      HasNoCompatibleTargetNoBorrow::hasNoCompatibleTarget(this, selfPos, derefChain, _)
     }
 
     /**
@@ -1839,8 +1831,8 @@ private module AssocFunctionResolution {
     predicate hasNoCompatibleNonBlanketTargetNoBorrow(
       FunctionPosition selfPos, DerefChain derefChain
     ) {
-      Foo<hasNoCompatibleNonBlanketTargetNoBorrowToIndex/4>::hasNoCompatibleNonBlanketTargetCheck(this,
-        selfPos, derefChain, _)
+      HasNoCompatibleNonBlanketTargetNoBorrow::hasNoCompatibleNonBlanketTarget(this, selfPos,
+        derefChain, _)
     }
 
     /**
@@ -1850,8 +1842,8 @@ private module AssocFunctionResolution {
      */
     pragma[nomagic]
     predicate hasNoCompatibleTargetSharedBorrow(FunctionPosition selfPos, DerefChain derefChain) {
-      Foo<hasNoCompatibleTargetSharedBorrowToIndex/4>::hasNoCompatibleNonBlanketLikeTargetCheck(this,
-        selfPos, derefChain, _)
+      HasNoCompatibleTargetSharedBorrow::hasNoCompatibleNonBlanketLikeTarget(this, selfPos,
+        derefChain, _)
     }
 
     /**
@@ -1861,8 +1853,8 @@ private module AssocFunctionResolution {
      */
     pragma[nomagic]
     predicate hasNoCompatibleTargetMutBorrow(FunctionPosition selfPos, DerefChain derefChain) {
-      Foo<hasNoCompatibleTargetMutBorrowToIndex/4>::hasNoCompatibleNonBlanketLikeTargetCheck(this,
-        selfPos, derefChain, _)
+      HasNoCompatibleTargetMutBorrow::hasNoCompatibleNonBlanketLikeTarget(this, selfPos, derefChain,
+        _)
     }
 
     /**
@@ -1874,8 +1866,8 @@ private module AssocFunctionResolution {
     predicate hasNoCompatibleNonBlanketTargetSharedBorrow(
       FunctionPosition selfPos, DerefChain derefChain
     ) {
-      Foo<hasNoCompatibleNonBlanketTargetSharedBorrowToIndex/4>::hasNoCompatibleNonBlanketTargetCheck(this,
-        selfPos, derefChain, _)
+      HasNoCompatibleNonBlanketTargetSharedBorrow::hasNoCompatibleNonBlanketTarget(this, selfPos,
+        derefChain, _)
     }
 
     /**
@@ -1887,8 +1879,8 @@ private module AssocFunctionResolution {
     predicate hasNoCompatibleNonBlanketTargetMutBorrow(
       FunctionPosition selfPos, DerefChain derefChain
     ) {
-      Foo<hasNoCompatibleNonBlanketTargetMutBorrowToIndex/4>::hasNoCompatibleNonBlanketTargetCheck(this,
-        selfPos, derefChain, _)
+      HasNoCompatibleNonBlanketTargetMutBorrow::hasNoCompatibleNonBlanketTarget(this, selfPos,
+        derefChain, _)
     }
 
     /**
@@ -1990,7 +1982,20 @@ private module AssocFunctionResolution {
   }
 
   bindingset[derefChain]
-  private predicate hasNoCompatibleNonBlanketTargetNoBorrowToIndex(
+  private predicate hasNoCompatibleTargetNoBorrowCand(
+    AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
+  ) {
+    afc.supportsAutoDerefAndBorrow() and
+    afc.hasReceiverAtPos(selfPos) and
+    exists(derefChain) and
+    borrow = TNoBorrowKind()
+  }
+
+  private module HasNoCompatibleTargetNoBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleTargetNoBorrowCand/4>;
+
+  bindingset[derefChain]
+  private predicate hasNoCompatibleNonBlanketTargetNoBorrowCand(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   ) {
     (
@@ -2009,48 +2014,53 @@ private module AssocFunctionResolution {
     borrow = TNoBorrowKind()
   }
 
+  private module HasNoCompatibleNonBlanketTargetNoBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleNonBlanketTargetNoBorrowCand/4>;
+
   pragma[nomagic]
-  private predicate hasNoCompatibleNonBlanketTargetSharedBorrowToIndex(
+  private predicate hasNoCompatibleTargetSharedBorrowCand(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   ) {
     afc.hasNoCompatibleTargetNoBorrow(selfPos, derefChain) and
     borrow = TSomeBorrowKind(false)
   }
 
+  private module HasNoCompatibleTargetSharedBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleTargetSharedBorrowCand/4>;
+
   pragma[nomagic]
-  private predicate hasNoCompatibleNonBlanketTargetMutBorrowToIndex(
+  private predicate hasNoCompatibleTargetMutBorrowCand(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   ) {
-    afc.hasNoCompatibleNonBlanketTargetSharedBorrow(selfPos, derefChain) and
+    afc.hasNoCompatibleTargetSharedBorrow(selfPos, derefChain) and
     borrow = TSomeBorrowKind(true)
   }
 
-  bindingset[derefChain]
-  private predicate hasNoCompatibleTargetNoBorrowToIndex(
-    AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
-  ) {
-    afc.supportsAutoDerefAndBorrow() and
-    afc.hasReceiverAtPos(selfPos) and
-    exists(derefChain) and
-    borrow = TNoBorrowKind()
-  }
+  private module HasNoCompatibleTargetMutBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleTargetMutBorrowCand/4>;
 
   pragma[nomagic]
-  private predicate hasNoCompatibleTargetSharedBorrowToIndex(
+  private predicate hasNoCompatibleNonBlanketTargetSharedBorrowCand(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   ) {
     afc.hasNoCompatibleTargetNoBorrow(selfPos, derefChain) and
     borrow = TSomeBorrowKind(false)
   }
 
+  private module HasNoCompatibleNonBlanketTargetSharedBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleNonBlanketTargetSharedBorrowCand/4>;
+
   pragma[nomagic]
-  private predicate hasNoCompatibleTargetMutBorrowToIndex(
+  private predicate hasNoCompatibleNonBlanketTargetMutBorrowCand(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   ) {
-    afc.hasNoCompatibleTargetSharedBorrow(selfPos, derefChain) and
+    afc.hasNoCompatibleNonBlanketTargetSharedBorrow(selfPos, derefChain) and
     borrow = TSomeBorrowKind(true)
   }
 
+  private module HasNoCompatibleNonBlanketTargetMutBorrow =
+    NoCompatibleTargetChecks<hasNoCompatibleNonBlanketTargetMutBorrowCand/4>;
+
   private import codeql.rust.elements.internal.generated.Raw
   private import codeql.rust.elements.internal.generated.Synth
 
@@ -2065,44 +2075,36 @@ private module AssocFunctionResolution {
   }
 
   bindingset[derefChain]
-  private signature predicate fooSig(
+  private signature predicate noCompatibleTargetCandSig(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
   );
 
-  private module Foo<fooSig/4 foo> {
+  private module NoCompatibleTargetChecks<noCompatibleTargetCandSig/4 noCompatibleTargetCand> {
     pragma[nomagic]
-    private predicate foo(
-      AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
-      TypePath strippedTypePath, Type strippedType, int n
-    ) {
-      foo(afc, selfPos, derefChain, borrow) and
-      strippedType = afc.getComplexStrippedSelfType(selfPos, derefChain, borrow, strippedTypePath) and
-      n = -1
-    }
-
-    pragma[nomagic]
-    private predicate bar(
+    private predicate noCompatibleNonBlanketLikeTargetCandNthLookupType(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
       TypePath strippedTypePath, Type strippedType, int n, Type t
     ) {
       (
-        foo(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n - 1) or
-        hasNoCompatibleNonBlanketLikeTargetCheckToIndex(afc, selfPos, derefChain, borrow,
+        noCompatibleTargetCand(afc, selfPos, derefChain, borrow) and
+        strippedType = afc.getComplexStrippedSelfType(selfPos, derefChain, borrow, strippedTypePath) and
+        n = 0
+        or
+        hasNoCompatibleNonBlanketLikeTargetForNthLookupType(afc, selfPos, derefChain, borrow,
           strippedTypePath, strippedType, n - 1)
       ) and
       t = getNthLookupType(afc, strippedType, n)
     }
 
     pragma[nomagic]
-    private ImplOrTraitItemNode getNthNonBlanketLikeCandidate(
+    private ImplOrTraitItemNode getKthNonBlanketLikeCandidateForNthLookupType(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
-      TypePath strippedTypePath, Type strippedType, int n, Type t, int rnk
+      TypePath strippedTypePath, Type strippedType, int n, Type t, int k
     ) {
-      bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) and
-      // foo(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, _) and
-      // t = getNthLookupType(afc, strippedType, n) and
+      noCompatibleNonBlanketLikeTargetCandNthLookupType(afc, selfPos, derefChain, borrow,
+        strippedTypePath, strippedType, n, t) and
       result =
-        rank[rnk + 1](ImplOrTraitItemNode i, int id |
+        rank[k + 1](ImplOrTraitItemNode i, int id |
           nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t) and
           id = idOfImplOrTraitItemNode(i)
         |
@@ -2111,19 +2113,13 @@ private module AssocFunctionResolution {
     }
 
     pragma[nomagic]
-    private int getLastNonBlanketLikeCandidateIndex(
+    private int getLastNonBlanketLikeCandidateForNthLookupType(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
       TypePath strippedTypePath, Type strippedType, int n
     ) {
-      // max(int rnk |
-      //   exists(
-      //     getNthNonBlanketLikeCandidate(afc, selfPos, derefChain, borrow, strippedTypePath,
-      //       strippedType, n, t, rnk)
-      //   )
-      // )
       exists(Type t |
-        foo(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, _) and
-        t = getNthLookupType(afc, strippedType, n) and
+        noCompatibleNonBlanketLikeTargetCandNthLookupType(afc, selfPos, derefChain, borrow,
+          strippedTypePath, strippedType, n, t) and
         result =
           count(ImplOrTraitItemNode i |
               nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t)
@@ -2133,73 +2129,67 @@ private module AssocFunctionResolution {
 
     // forex using recursion
     pragma[nomagic]
-    private predicate hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(
+    private predicate hasNoCompatibleNonBlanketLikeTargetForNthLookupTypeToIndex(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
-      TypePath strippedTypePath, Type strippedType, int n, int rnk
+      TypePath strippedTypePath, Type strippedType, int n, int k
     ) {
-      // afc = Debug::getRelevantLocatable() and
-      exists(Type t | bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) |
-        rnk = -1
+      exists(Type t |
+        noCompatibleNonBlanketLikeTargetCandNthLookupType(afc, selfPos, derefChain, borrow,
+          strippedTypePath, strippedType, n, t)
+      |
+        k = -1
         or
-        hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(afc, selfPos, derefChain, borrow,
-          strippedTypePath, strippedType, n, rnk - 1) and
+        hasNoCompatibleNonBlanketLikeTargetForNthLookupTypeToIndex(afc, selfPos, derefChain, borrow,
+          strippedTypePath, strippedType, n, k - 1) and
         exists(ImplOrTraitItemNode i |
           i =
-            getNthNonBlanketLikeCandidate(afc, selfPos, derefChain, borrow, strippedTypePath,
-              strippedType, n, t, rnk) and
+            getKthNonBlanketLikeCandidateForNthLookupType(afc, selfPos, derefChain, borrow,
+              strippedTypePath, strippedType, n, t, k) and
           afc.hasIncompatibleTarget(i, selfPos, derefChain, borrow, t)
         )
       )
     }
 
     // forex using recursion
     pragma[nomagic]
-    private predicate hasNoCompatibleNonBlanketLikeTargetCheckToIndex(
+    private predicate hasNoCompatibleNonBlanketLikeTargetForNthLookupType(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
       TypePath strippedTypePath, Type strippedType, int n
     ) {
       exists(int last |
         last =
-          getLastNonBlanketLikeCandidateIndex(afc, selfPos, derefChain, borrow, strippedTypePath,
-            strippedType, n) and
-        hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(afc, selfPos, derefChain, borrow,
+          getLastNonBlanketLikeCandidateForNthLookupType(afc, selfPos, derefChain, borrow,
+            strippedTypePath, strippedType, n) and
+        hasNoCompatibleNonBlanketLikeTargetForNthLookupTypeToIndex(afc, selfPos, derefChain, borrow,
           strippedTypePath, strippedType, n, last)
       )
-      // exists(Type t |
-      //   bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) and
-      //   forall(ImplOrTraitItemNode i |
-      //     nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t)
-      //   |
-      //     afc.hasIncompatibleTarget(i, selfPos, derefChain, borrow, t)
-      //   )
-      // )
     }
 
     pragma[nomagic]
-    predicate hasNoCompatibleNonBlanketLikeTargetCheck(
+    predicate hasNoCompatibleNonBlanketLikeTarget(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
     ) {
       exists(Type strippedType |
-        hasNoCompatibleNonBlanketLikeTargetCheckToIndex(afc, selfPos, derefChain, borrow, _,
+        hasNoCompatibleNonBlanketLikeTargetForNthLookupType(afc, selfPos, derefChain, borrow, _,
           strippedType, getLastLookupTypeIndex(afc, strippedType))
       )
     }
 
     pragma[nomagic]
-    predicate hasNoCompatibleTargetCheck(
+    predicate hasNoCompatibleTarget(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
     ) {
-      hasNoCompatibleNonBlanketLikeTargetCheck(afc, selfPos, derefChain, borrow) and
+      hasNoCompatibleNonBlanketLikeTarget(afc, selfPos, derefChain, borrow) and
       forall(ImplItemNode i | blanketLikeCandidate(afc, selfPos, i, _, _, _) |
         afc.hasIncompatibleBlanketLikeTarget(i, selfPos, derefChain, borrow)
       )
     }
 
     pragma[nomagic]
-    predicate hasNoCompatibleNonBlanketTargetCheck(
+    predicate hasNoCompatibleNonBlanketTarget(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
     ) {
-      hasNoCompatibleNonBlanketLikeTargetCheck(afc, selfPos, derefChain, borrow) and
+      hasNoCompatibleNonBlanketLikeTarget(afc, selfPos, derefChain, borrow) and
       forall(ImplItemNode i |
         blanketLikeCandidate(afc, selfPos, i, _, _, _) and
         not i.isBlanketImplementation()