Skip to content

Commit a652892

Browse files
committed
QL: better support for getType on super
1 parent 928b91d commit a652892

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ql/src/codeql_ql/ast/Ast.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1765,8 +1765,7 @@ class Super extends TSuper, Expr {
17651765
override string getAPrimaryQlClass() { result = "Super" }
17661766

17671767
override Type getType() {
1768-
exists(TypeExpr te | ref.getChild(0) = toQL(te) | result = te.getResolvedType())
1769-
// TODO: Also resolve the type when there is no TypeExpr.
1768+
exists(MemberCall call | call.getBase() = this | result = call.getTarget().getDeclaringType())
17701769
}
17711770
}
17721771

ql/test/type/type.expected

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,5 @@
5050
| Test.qll:24:24:24:33 | Super | Test.qll:15:1:19:1 | Base |
5151
| Test.qll:24:24:24:39 | MemberCall | file://:0:0:0:0 | int |
5252
| Test.qll:26:16:26:21 | result | file://:0:0:0:0 | int |
53+
| Test.qll:26:25:26:29 | Super | Test.qll:15:1:19:1 | Base |
5354
| Test.qll:26:25:26:35 | MemberCall | file://:0:0:0:0 | int |

0 commit comments

Comments
 (0)